Skip to content

fix(container): default registry_image to nginx:latest when omitted at create time #3947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jremy42 wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −0
Draft

fix(container): default registry_image to nginx:latest when omitted at create time #3947

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions internal/services/container/helpers_container.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ const (
defaultContainerDomainTimeout = 10 * time.Minute
DefaultContainerRetryInterval = 5 * time.Second
defaultTriggerRetryInterval = 5 * time.Second
// The API requires a valid image on create even though registry_image is optional.
defaultContainerRegistryImage = "nginx:latest"
)

// newAPIWithRegion returns a new container API and the region.
Expand Down Expand Up @@ -108,6 +110,8 @@ func setCreateContainerRequest(d *schema.ResourceData, region scw.Region) (*cont

if registryImage, ok := d.GetOk("registry_image"); ok {
req.RegistryImage = types.ExpandStringPtr(registryImage)
} else {
req.RegistryImage = types.ExpandStringPtr(defaultContainerRegistryImage)
}

if maxConcurrency, ok := d.GetOk("max_concurrency"); ok {
Expand Down
Loading