Refactor FlexibleType to use TypeBounds instead of case class#26245
Draft
HarrisL2 wants to merge 2 commits into
Draft
Refactor FlexibleType to use TypeBounds instead of case class#26245HarrisL2 wants to merge 2 commits into
HarrisL2 wants to merge 2 commits into
Conversation
Member
|
I don't think this is going in the right direction. Superficially, this may allow some macro test suites to pass in the short term. But the logic will probably be broken anyway. And in the long term, this will just force macros to handle flexible type specially anyway, like the compiler. IMO we should stick with the correct design with real |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors FlexibleTypes to have TypeBounds as underlying representation, which can help with macro-related code avoid match errors.
The key change is in Definitions.scala
How much have you relied on LLM-based tools in this contribution?
Minimally, for some refactoring
How was the solution tested?
Covered by existing tests (this is a refactoring)