Fix ASTNode's copyNode for constants. - #485
Open
luciansmith wants to merge 2 commits into
Open
Conversation
We weren't replacing 'name' with NULL, so the old name persisted. Discovered when using the function definition converter on SBML Test Suite models.
Member
|
@luciansmith while i agree, that the name ought to be set. I just wonder, whether copyNode should not copy the 'name' from source. is it not the case, that an application could use other than those names for the constant types? |
Member
Author
|
Oh! You remembered better than I; I had forgotten that the 'name' of a constant could also be set. I'll make the change. |
A predefined constant in libsbml can have its own name set, in case someone wants alternate text for the node.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bug showed up when using the FunctionDefinitionConverter on SBML Test Suite models. (Tests added.)