Y26-125 dual index tags update in mlwh#5745
Conversation
…uses to prevent NoMethod errors, and updated specialised fields to pass in row to enab
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5745 +/- ##
===========================================
- Coverage 87.34% 87.30% -0.04%
===========================================
Files 1479 1479
Lines 33601 33594 -7
Branches 3562 3566 +4
===========================================
- Hits 29349 29330 -19
- Misses 4231 4243 +12
Partials 21 21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
StephenHulme
left a comment
StephenHulme
left a comment
There was a problem hiding this comment.
Might benefit from someone more familiar with aliquots, but looks good to me.
| # NB. the asset here is a well, and the well_has_single_aliquot? validation ensures there is only one aliquot | ||
| # NB. we are fetching via row so this is the same aliquot instance so saved_changes? works to detect | ||
| # substitutions | ||
| row.aliquots.first.assign_attributes(tag:, tag2:) |
There was a problem hiding this comment.
| row.aliquots.first.assign_attributes(tag:, tag2:) | |
| aliquots.first.assign_attributes(tag:, tag2:) |
I think we don't need the row passed through. If you look at the code for the other types of library manifest, they reference aliquots directly (which is delegated to asset on the base class) - so should work to do the same here.
Equivalent classes for other manifests:
app/sequencescape_excel/sequencescape_excel/specialised_field/i7.rb>app/sample_manifest_excel/sample_manifest_excel/tags/aliquot_updater.rbapp/sequencescape_excel/sequencescape_excel/specialised_field/tag_index.rb
There was a problem hiding this comment.
without the row it does not set up the tag substitutions.
different aliquot instances I think?
There was a problem hiding this comment.
possibly points to some other flaw in how this is working, but I can't see it.
There was a problem hiding this comment.
Will have a play with it when I have a moment 🤔
KatyTaylor
left a comment
KatyTaylor
left a comment
There was a problem hiding this comment.
Looks great, except I think you can take the row-related changes out, to simplify even more.
…iquots.first was doing a new select query on CollectionProxy and then the updated aliquot instances were different
KatyTaylor
left a comment
KatyTaylor
left a comment
There was a problem hiding this comment.
Left a small wording suggestion but looks good, thanks for figuring out that row thing.
…dual_index_tag_well.rb Co-authored-by: KatyTaylor <kt17@sanger.ac.uk>
…anger/sequencescape into Y26-125-dual-index-tags-update-in-mlwh
3 participants
Closes #5677
Changes proposed in this pull request