Save and delete works cleanly

[laritakr]

Summary

• Saving or deleting a work no longer produces a 500 when the redirects feature is on but the redirects database table isn't reachable — the work save goes through cleanly and the redirect update is skipped for that request.
• Refs Hyrax: rescue StatementInvalid in SyncRedirectPaths/RemoveRedirectPaths notch8/palni_palci_knapsack#646.

Details

When a tenant has the redirects feature enabled but the migration that creates the redirects database table hasn't been run, the redirects sync/remove steps were letting the database error escape, producing a 500 — even though the work itself had already saved successfully. The user was left looking at a stack trace with no clear recovery path.

This change has the sync and remove steps catch that error, log it, and return a clean failure to the controller instead. Redirects are a sidecar to the work, not load-bearing for it, so a soft fail is the right outcome: the work save still succeeds, and only the redirect bookkeeping is skipped for that request.

The issue surfaced during early Hyku integration testing when the migration hadn't been installed yet.

The primary fixes are in:

• remove_redirect_paths.rb
• sync_redirect_paths.rb

The remainder of changes are in specs and documentation. As this change would have introduced several more locations of using either "ledger" and "redirects table" with the same meaning, it renames "ledger" terminology to "redirects table" throughout the related code and docs for clearer language.

Testing

• In a Hyku tenant with the redirects feature enabled but the migration not run, saving a work produces a clean error rather than a 500.
• Same scenario but on delete: deleting a work with the migration not run produces a clean error rather than a 500.

[github-actions]

Test Results

    17 files  ±0      17 suites  ±0   3h 24m 16s ⏱️ - 5m 38s
 7 338 tests +2   7 032 ✅ +2  306 💤 ±0  0 ❌ ±0 
24 694 runs  +8  24 103 ✅ +8  591 💤 ±0  0 ❌ ±0 

Results for commit 0afeda8. ± Comparison against base commit cae6920.

This pull request removes 436 and adds 438 tests. Note that renamed tests count towards both.

spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007efd87f90160>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f43517afc88>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f940c3e3d50>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fb14017d498>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007efd880cb2c8>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f43517bc1e0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f940c403218>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fb14085e258>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 03bcd766-44a7-4c85-a114-cc0a95c5566b
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 7913a7b4-338a-4103-bd3e-5d961108ea33
…

spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f01d7c46f50>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f409e61d498>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f4f291521e0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f7fea68fb48>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f01d7f73fc0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f409e3ae608>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f4f29199748>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f7fea69c1e0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 06ea84ae-9eee-4bac-a923-971eda63e7f0
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 05c1222f-6ceb-41fc-bdfd-d1db3db7ef5c
…