Add validation to local controlled vocabulary#7423
Open
Conversation
Test Results 17 files ± 0 17 suites ±0 3h 22m 3s ⏱️ - 7m 51s Results for commit 0c91161. ± Comparison against base commit cae6920. This pull request removes 436 and adds 447 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
74799f7 to
7b9f23a
Compare
The only defense against bad data for controlled vocabulary fields exists in the frontend with the select options. This commit will introduce a validator for local controlled vocabulary terms by way of Questioning Authority lookups which would ensure that anything interacting directly with the backend would only be allowed to input valid terms.
The reasoning is that some institutions may be adding to their controlled vocabulary on a continous basis without adding it to their backend each time. The validation would break their workflow so instead this will be an opt-in feature.
62f46fc to
c1d49aa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only defense against bad data for controlled vocabulary fields exists in the frontend with the select options. This commit will introduce a validator for local controlled vocabulary terms by way of Questioning Authority lookups which would ensure that anything interacting directly with the backend would only be allowed to input valid terms.
@samvera/hyrax-code-reviewers