Skip to content

Fixed Create mechanical rollers not filling correctly by bypassing block breaking distance check - #1393

Closed
adityapatn wants to merge 1 commit into
ryanhcode:mainfrom
adityapatn:main
Closed

Fixed Create mechanical rollers not filling correctly by bypassing block breaking distance check#1393
adityapatn wants to merge 1 commit into
ryanhcode:mainfrom
adityapatn:main

Conversation

@adityapatn

Copy link
Copy Markdown

Create mechanical rollers' "Sloped Fill" and "Straight Fill" modes interact with blocks much further away than other actors, and so should be excluded from Sable's distance check on whether to cancel the interaction in testBreakingPosDist in BlockBreakingMovementBehaviourMixin.java.

Error: Create Mechanical Rollers on Create trains do not fill below the first layer when Create and Sable are installed (Latest versions for Neoforge 1.21.1).

Fix: Add check for whether the MovementBehaviour is a RollerMovementBehaviour in the distance check in testBreakingPosDist.

@CLAassistant

CLAassistant commented Jul 25, 2026

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@adityapatn adityapatn changed the title Bypassed block breaking distance check for Create mechanical rollers Fixed Create mechanical rollers not filling correctly by bypassing block breaking distance check Jul 25, 2026
@ryanhcode

Copy link
Copy Markdown
Owner

Should be fixed in main

@ryanhcode ryanhcode closed this Aug 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants