Skip to content

android: advance the #836 watermark after the post-backfill re-score #1120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryanbr merged 1 commit into from
Aug 7, 2026
Merged

android: advance the #836 watermark after the post-backfill re-score #1120

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions android/app/src/main/java/com/noop/ble/WhoopBleClient.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2071,6 +2071,16 @@ class WhoopBleClient(
sex = profileStore.sex,
stepTicksPerStep = profileStore.stepTicksPerStep,
)
// #836: the post-backfill pass is a real update path, so it ALWAYS re-scores (mirroring the
// Swift `analyzeRecent(force: true)` call `refreshAfterCompletedBackfill` makes) — but it must
// ADVANCE the shared HR-fingerprint watermark on success, which it previously did NOT. That
// watermark logic lived only in AppViewModel's 15-min loop, so after this pass the very next
// idle tick saw `fp != watermark` and re-ran the IDENTICAL maxDays×~54h re-score — the
// double-charge that made every reconnect pay for the multi-day pass twice. Swift already
// advances the watermark at the end of EVERY successful analyzeRecent (IntelligenceEngine.swift);
// this brings Android into lockstep. Captured before the run, written only on success, so an
// interrupted/failed pass can never advance the watermark past unscored data.
val analyzeFp = repository.hrFingerprint()
runCatching {
IntelligenceEngine.analyzeRecent(
repo = repository,
Expand Down Expand Up @@ -2143,6 +2153,8 @@ class WhoopBleClient(
else null,
)
}.onSuccess {
// Advance the shared watermark so the next 15-min tick sees no change and skips (#836).
NoopPrefs.setAnalyzeWatermark(context, analyzeFp)
log("Backfill: post-sync scoring pass done")
// #277 diagnostic: surface the day-key the dashboard treats as "today" against the
// newest banked row, so a UTC-bucket vs local-day split (rows persist but Today
Expand Down