Implement directoryName constraint validation#489
Open
sfackler wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #489 +/- ##
==========================================
+ Coverage 97.01% 97.05% +0.04%
==========================================
Files 20 21 +1
Lines 3950 4379 +429
==========================================
+ Hits 3832 4250 +418
- Misses 118 129 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
What's your use case for this? |
Author
|
I am unfortunately trying to deal with a (privately issued) cert issued by an intermediate with DN constraints. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few notes:
GeneralName::from_der.rdn_eqis an O(n^2) nested loop around the two sets of AVAs. This mirrors the overall approach taken in BoringSSL, though the one here is implemented with fixed size buffers and a bitmask rather than vectors to keep everything no-std.Depends on rustls/rcgen#429, so I have a Cargo patch for rcgen until a new release gets cut.
Closes #19