Add println!() support, working in Dolphin#12
Merged
Conversation
Once rust-wii#9 gets fixed to work with a real USB Gecko, this will have to do as a way to communicate with the outside world for debugging purposes. I quite dislike how the alloc and luma_core crates must be imported under these names in order for my macro to work, but I couldn’t figure out a better way which still compiles.
This has the same limitation as println!(), it works only in Dolphin until rust-wii#9 gets merged.
633d416 to
7d2fe67
Compare
Contributor
|
LGTM, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Once #9 gets fixed to work with a real USB Gecko, this will have to do as a way to communicate with the outside world for debugging purposes.
I quite dislike how the
allocandluma_corecrates must be imported under these names in order for my macro to work, but I couldn’t figure out a better way which still compiles.It also displays
panic!()info using this new printing facility.