Skip to content

Use cross-platform capability in enable_cap example #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rogersnm wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use cross-platform capability in enable_cap example #384

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 12 additions & 17 deletions kvm-ioctls/src/ioctls/vm.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1503,26 +1503,21 @@ impl VmFd {
/// extern crate kvm_bindings;
///
/// # use kvm_ioctls::Kvm;
/// use kvm_bindings::{KVM_CAP_SPLIT_IRQCHIP, kvm_enable_cap};
/// use kvm_bindings::{KVM_CAP_HALT_POLL, kvm_enable_cap};
///
/// let kvm = Kvm::new().unwrap();
/// let vm = kvm.create_vm().unwrap();
/// let mut cap: kvm_enable_cap = Default::default();
/// cap.cap = KVM_CAP_SPLIT_IRQCHIP;
/// // As per the KVM documentation, KVM_CAP_SPLIT_IRQCHIP only emulates
/// // the local APIC in kernel, expecting that a userspace IOAPIC will
/// // be implemented by the VMM.
/// // Along with this capability, the user needs to specify the number
/// // of pins reserved for the userspace IOAPIC. This number needs to be
/// // provided through the first argument of the capability structure, as
/// // specified in KVM documentation:
/// // args[0] - number of routes reserved for userspace IOAPICs
/// //
/// // Because an IOAPIC supports 24 pins, that's the reason why this test
/// // picked this number as reference.
/// cap.args[0] = 24;
/// #[cfg(target_arch = "x86_64")]
/// vm.enable_cap(&cap).unwrap();
///
/// if kvm.check_extension_raw(KVM_CAP_HALT_POLL.into()) > 0 {
/// let cap = kvm_enable_cap {
/// cap: KVM_CAP_HALT_POLL,
/// // Set the maximum halt-polling time to 100 microseconds.
/// args: [100_000, 0, 0, 0],
/// ..Default::default()
/// };
///
/// vm.enable_cap(&cap).unwrap();
/// }
/// ```
pub fn enable_cap(&self, cap: &kvm_enable_cap) -> Result<()> {
// SAFETY: The ioctl is safe because we allocated the struct and we know the
Expand Down