Skip to content

nostr: add nip47 accepted state for hold invoices #1125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yukibtc merged 2 commits into from
Feb 4, 2026
Merged

nostr: add nip47 accepted state for hold invoices #1125

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ab3ad2
nostr: add nip47 accepted state for hold invoices
daywalker90 Nov 7, 2025
3f475e8
nostr: rename nip47's MakeHoldInvoiceRequest's cltv_expiry_delta to m…
daywalker90 Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion crates/nostr/src/nips/nip47.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,6 +452,9 @@ pub enum TransactionState {
/// Failed (for payments)
#[serde(rename = "failed")]
Failed,
/// Accepted (for hold invoices)
#[serde(rename = "accepted")]
Accepted,
}

/// List Transactions Request
Expand Down Expand Up @@ -496,7 +499,7 @@ pub struct MakeHoldInvoiceRequest {
pub payment_hash: String,
/// The minimum CLTV delta to use for the final hop
#[serde(skip_serializing_if = "Option::is_none")]
pub cltv_expiry_delta: Option<u32>,
pub min_cltv_expiry_delta: Option<u32>,
}

/// Cancel Hold Invoice Request
Expand Down Expand Up @@ -1503,6 +1506,9 @@ pub struct HoldInvoiceAcceptedNotification {
/// Transaction type
#[serde(rename = "type")]
pub transaction_type: TransactionType,
/// Transaction state
#[serde(skip_serializing_if = "Option::is_none")]
pub state: Option<TransactionState>,
/// Bolt11 invoice
pub invoice: String,
/// Description
Expand Down
Loading