Some more changes in stdarch-gen-arm#2105
Merged
folkertdev merged 3 commits intorust-lang:mainfrom May 7, 2026
Merged
Conversation
sayantn
force-pushed
the
gen-arm-improvements
branch
2 times, most recently
from
8bc2159 to
49c2820
Compare
Changes the definition of `vabdl_high_u{8,16,32}` to match that of
`vabdl_high_s{8,16,32}` so that the `big_endian_inverse` transformation
can apply.
Writing these intrinsics in terms of the `vqtbl_$ty` functions rather than the `vqtbl` helper function preserves the behaviour while making them work in big endian.
Writing these intrinsics in terms of the `vqtbx_$ty` functions rather than the `vqtbx` helper function preserves the behaviour while making them work in big endian.
sayantn
force-pushed
the
gen-arm-improvements
branch
from
49c2820 to
8f84a30
Compare
folkertdev
approved these changes
May 7, 2026
Contributor
There was a problem hiding this comment.
Looks fine, and I'm happy to unblock the main PR. Some things we could follow up on
crate::mem::zeroed()can probably be replaced byvec_ty::ZERO- functions like
vreinterpret_u8_s8probably don't need a separate big-endian implementation (in most cases?)
Contributor
Author
|
I tried to put the |
Contributor
|
Perhaps it should use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
attempting to make push some more changes to stdarch-gen-arm standalone before #2063. Again, all commits are by @davidtwco.
r? @folkertdev