Skip to content

loongarch: Use intrinsics::simd for vadda#2103

Merged
sayantn merged 1 commit intorust-lang:mainfrom
heiher:vadda
May 10, 2026
Merged

loongarch: Use intrinsics::simd for vadda#2103
sayantn merged 1 commit intorust-lang:mainfrom
heiher:vadda

Conversation

@heiher
Copy link
Copy Markdown
Contributor

@heiher heiher commented May 6, 2026

No description provided.

@heiher
Copy link
Copy Markdown
Contributor Author

heiher commented May 6, 2026

@rustbot

This comment has been minimized.

@heiher heiher marked this pull request as ready for review May 9, 2026 08:09
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 9, 2026

r? @sayantn

rustbot has assigned @sayantn.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @Amanieu, @folkertdev, @sayantn
  • @Amanieu, @folkertdev, @sayantn expanded to Amanieu, folkertdev, sayantn
  • Random selection from Amanieu, folkertdev, sayantn

Copy link
Copy Markdown
Contributor

@sayantn sayantn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one query. The reference doesn't specify what happens, e.g. for xvadda_b(-128, -128). The implementation suggests it is wrapping to 0, just making sure that it is the correct behavior

View changes since this review

@heiher
Copy link
Copy Markdown
Contributor Author

heiher commented May 10, 2026

LGTM, just one query. The reference doesn't specify what happens, e.g. for xvadda_b(-128, -128). The implementation suggests it is wrapping to 0, just making sure that it is the correct behavior

Yeah, I made sure that it uses wrapping addition. Thanks

@sayantn sayantn added this pull request to the merge queue May 10, 2026
Merged via the queue into rust-lang:main with commit d167cf8 May 10, 2026
76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants