Allow Trait inheritance with cycles on associated types#79209

Merged

bors merged 28 commits into

rust-lang:masterfrom

spastorino:trait-inheritance-self

Nov 29, 2020

Commits on Nov 27, 2020

Allow to use super trait bounds in where clauses
spastorino
committed
Allow to self reference associated types in where clauses
spastorino
committed
Update tests
spastorino
committed
Add test to check that we do not get a cycle due to resolving `Self::Bar` in the where clauses

nikomatsakis
authored and
spastorino
committed
Fix super_traits_of to consider where bounds
spastorino
committed
Avoid ICEing when associated type bound trait is missing
spastorino
committed
Add test for a still ambiguous scenario
spastorino
committed
Add description on test
spastorino
committed
Add `` to variable name in docs
spastorino
committed
Extract trait_may_define_assoc_type helper function
spastorino
committed
Remove unneeded logic
spastorino
committed
super_traits_of is now a query
spastorino
committed
Extract function trait_may_define_assoc_type
spastorino
committed
compute_bounds takes &[GenericBound]
spastorino
committed
Bless tests
spastorino
committed
adjust super_predicates_that_define_assoc_type query description
spastorino
committed
Add super_traits_of docs
spastorino
committed
Document compute_bounds_that_match_assoc_type
spastorino
committed
Document elaborate_trait_refs_that_define_assoc_type
spastorino
committed
Inline elaborate_trait_refs_that_define_assoc_type into transitive_bounds_that_define_assoc_type
spastorino
committed
Fix super_predicates_that_define_assoc_type API doc
spastorino
committed
Fix super_traits_of API doc
spastorino
committed
Make super_traits_of return Lrc for cheaper clone
spastorino
committed
Add test to check that we handle predicates that can define assoc types correctly
spastorino
committed
Simplify super_traits_of
spastorino
committed
Remove super_traits_of query, just leave a helper function
spastorino
committed
Make super_traits_of return an iterator
spastorino
committed
Return FxIndexSet instead of FxHashSet to avoid order errors on different platforms
spastorino
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Allow Trait inheritance with cycles on associated types#79209

Allow Trait inheritance with cycles on associated types#79209
bors merged 28 commits into
rust-lang:masterfrom
spastorino:trait-inheritance-self

Commits on Nov 27, 2020

Allow to use super trait bounds in where clauses

Allow to self reference associated types in where clauses

Update tests

Add test to check that we do not get a cycle due to resolving `Self::Bar` in the where clauses

Fix super_traits_of to consider where bounds

Avoid ICEing when associated type bound trait is missing

Add test for a still ambiguous scenario

Add description on test

Add `` to variable name in docs

Extract trait_may_define_assoc_type helper function

Remove unneeded logic

super_traits_of is now a query

Extract function trait_may_define_assoc_type

compute_bounds takes &[GenericBound]

Bless tests

adjust super_predicates_that_define_assoc_type query description

Add super_traits_of docs

Document compute_bounds_that_match_assoc_type

Document elaborate_trait_refs_that_define_assoc_type

Inline elaborate_trait_refs_that_define_assoc_type into transitive_bounds_that_define_assoc_type

Fix super_predicates_that_define_assoc_type API doc

Fix super_traits_of API doc

Make super_traits_of return Lrc for cheaper clone

Add test to check that we handle predicates that can define assoc types correctly

Simplify super_traits_of

Remove super_traits_of query, just leave a helper function

Make super_traits_of return an iterator

Return FxIndexSet instead of FxHashSet to avoid order errors on different platforms