Refactorings in preparation for const value trees#77227

Merged

bors merged 26 commits into

rust-lang:masterfrom

oli-obk:const_val_🌳_prelude

Nov 4, 2020

Commits on Nov 4, 2020

Split the "raw integer bytes" part out of `Scalar`
oli-obk
committed
Encode `ScalarInt::bytes` as `u128` instead of `[u8; 16]` to see if that caused the performance regression
oli-obk
committed
32 bit platforms don't have 64 bit pointers
oli-obk
committed
Use packed struct instead of manually packing into an array
oli-obk
committed
Explain the use of blocks around `self.data` accesses
oli-obk
committed
Fix cranelift build
oli-obk
committed
s/Scalar::Raw/Scalar::Int
oli-obk
committed
Remove outdated FIXME
oli-obk
committed
Unaligned reads are UB in Rust irrelevant on which platform we are
oli-obk
committed
Update comment
oli-obk
committed
No need for a `zst` constructor method when we can have a constant
oli-obk
committed
Replace `Scalar::zst` with a `Scalar::ZST` constant
oli-obk
committed
catch conversion errors during `ptr_sized_op`
oli-obk
committed
Explain why we forward to self-printing during self-printing
oli-obk
committed
Add `is_null` helper
oli-obk
committed
Add helper for getting an `int` out of a `Scalar`
oli-obk
committed
Do not raise interp errors from the scalar int module
oli-obk
committed
Simplify `assert_bits` impl
oli-obk
committed
Update compiler/rustc_middle/src/ty/consts/int.rs

oli-obk
and
RalfJung
committed
Move ZST constant to the top of the impl block
oli-obk
committed
`u128` truncation and sign extension are not just interpreter related
oli-obk
committed
Document an `unwrap`
oli-obk
committed
Make `ScalarInt` entirely independent of MIR interpretation
oli-obk
committed
`u64::try_from` will now fail if `ScalarInt` isn't exactly 64 bits, thus we use `to_bits` with the correct size
oli-obk
committed
Update compiler/rustc_target/src/abi/mod.rs

oli-obk
and
RalfJung
authored
Update compiler/rustc_target/src/abi/mod.rs

oli-obk
and
RalfJung
authored

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Refactorings in preparation for const value trees#77227

Hidden character warning

Refactorings in preparation for const value trees#77227
bors merged 26 commits into
rust-lang:masterfrom
oli-obk:const_val_🌳_prelude

Commits on Nov 4, 2020

Split the "raw integer bytes" part out of `Scalar`

Encode `ScalarInt::bytes` as `u128` instead of `[u8; 16]` to see if that caused the performance regression

32 bit platforms don't have 64 bit pointers

Use packed struct instead of manually packing into an array

Explain the use of blocks around `self.data` accesses

Fix cranelift build

s/Scalar::Raw/Scalar::Int

Remove outdated FIXME

Unaligned reads are UB in Rust irrelevant on which platform we are

Update comment

No need for a `zst` constructor method when we can have a constant

Replace `Scalar::zst` with a `Scalar::ZST` constant

catch conversion errors during `ptr_sized_op`

Explain why we forward to self-printing during self-printing

Add `is_null` helper

Add helper for getting an `int` out of a `Scalar`

Do not raise interp errors from the scalar int module

Simplify `assert_bits` impl

Update compiler/rustc_middle/src/ty/consts/int.rs

Move ZST constant to the top of the impl block

`u128` truncation and sign extension are not just interpreter related

Document an `unwrap`

Make `ScalarInt` entirely independent of MIR interpretation

`u64::try_from` will now fail if `ScalarInt` isn't exactly 64 bits, thus we use `to_bits` with the correct size

Update compiler/rustc_target/src/abi/mod.rs

Update compiler/rustc_target/src/abi/mod.rs