Rollup of 11 pull requests by JonathanBrouwer · Pull Request #156371 · rust-lang/rust

JonathanBrouwer · 2026-05-09T18:53:20Z

Successful merges:

Consider Result<T, Uninhabited> and ControlFlow<Uninhabited, T> to be equivalent to T for must use lint #148214 (Consider Result<T, Uninhabited> and ControlFlow<Uninhabited, T> to be equivalent to T for must use lint)
Add Command::get_resolved_envs #149362 (Add Command::get_resolved_envs)
[Debug Info] Gracefully handle invalid String/Vec #155509 ([Debug Info] Gracefully handle invalid String/Vec)
Add str::word_to_titlecase() to alloc #155705 (Add str::word_to_titlecase() to alloc)
Add mention of sendfile(2) and splice(2) to fs::copy() documentation. #155970 (Add mention of sendfile(2) and splice(2) to fs::copy() documentation.)
Update a bunch of bootstrap dependencies to remove windows-target #156006 (Update a bunch of bootstrap dependencies to remove windows-target)
Add regression test for issue 144329 #155188 (Add regression test for issue 144329)
error on empty export_name #155515 (error on empty export_name)
validate #[link_name = "..."] & #[link(name = "...")] parameters #155817 (validate #[link_name = "..."] & #[link(name = "...")] parameters)
remove turbofish notation + use None / Some instead of Option:: (in match documentation) #156107 (remove turbofish notation + use None / Some instead of Option:: (in match documentation))
mark some panicking methods around Duration as track_caller #156133 (mark some panicking methods around Duration as track_caller)

This addition allows an end-user to inspect the environment variables that are visible to the process when it boots.

…use lint (or more accurately `Result<T, Uninhabited>`/`ControlFlow<Uninhabited, T>`). This generalizes a previous change where we only did this for `T = ()`.

specifically, do not allow NULL bytes and the empty string

* Add `str::word_to_titlecase()` to `alloc` * Address review comment

* Add mention of sendfile(2) and splice(2) to fs::copy() documentation. * Oxford comma fix

…, r=fee1-dead Consider `Result<T, Uninhabited>` and `ControlFlow<Uninhabited, T>` to be equivalent to `T` for must use lint This is an extension to rust-lang#147382. With this PR `Result<T, Uninhabited>` and `ControlFlow<Uninhabited, T>` considered as must use iif `T` must be used. For such cases the lint will mention that `T` is wrapped in a `Result`/`ControlFlow` with an uninhabited error/break. The reasoning here is that `Result<T, Uninhabited>` is equivalent to `T` in which values can be represented and thus the must-used-ness should also be equivalent. Fixes rust-lang#65861

…s, r=Mark-Simulacrum Add Command::get_resolved_envs This addition allows an end-user to inspect the environment variables that are visible to the process when it boots. Discussed in: - Tracking issue: rust-lang#149070 (partially closes) - ACP: rust-lang/libs-team#194

…ulacrum [Debug Info] Gracefully handle invalid `String`/`Vec` Somewhat related to rust-lang#150392. Currently the handling can throw an exception, which we should absolutely not do. It causes issues with debugger adapters (e.g. CodeLLDB will hang forever. Trying to stop the debugger via vscode's interface causes a CodeLLDB to leak memory constantly until RAM is depleted and the OS starts killing processes). The exception has been replaced with a printed error message and a placeholder value. Additionally, if a String/Vec is in an "invalid" state due to niche optimization (`capacity >= (1 << 63)`, common with `Option<String>`/`Option<Vec<T>>`), the pointer and length values will be meaningless, but are not guaranteed to be 0'd. The debugger will happily proceed as if they are useful values, and often do things like \<try to read multiple GB of data from the debugee\>. I added simple checks to ensure that the capacity and length are within bounds, and that the pointer is non-null. If any check fails, the string/vec just acts as if it's empty. Eventually this problem will be solved on LLDB's end via llvm/llvm-project#188487 or similar, but preventing issues on our end in the short term will help a lot.

@rustbot

… r=Mark-Simulacrum Add `str::word_to_titlecase()` to `alloc` A small addition to rust-lang#153892. Hasn't gone through ACP, so needs libs-API signoff. @rustbot label A-Unicode T-libs-api

…riplett Add mention of sendfile(2) and splice(2) to fs::copy() documentation. Fixes rust-lang#155968 by adding mention of sendfile(2) and splice(2) from io::copy()

…=Mark-Simulacrum Update a bunch of bootstrap dependencies to remove windows-target Follow up to rust-lang#155444

…lacrum Add regression test for issue 144329 Closes rust-lang#144329.

…r=jdonszelmann error on empty `export_name` fixes rust-lang#155495 Using an empty string as the name makes LLVM make up a name. However this name can be inconsistent between compilation units, which is UB and can cause linking errors, and some parts of LLVM just crash on the empty name (see the linked issue). As far as we know there is only one valid pattern that could use this, a `#[used]` static that is not referenced by the program at all. That is not UB, but the `export_name` is not required for that to work, just normal rust name mangling would do fine. Technically this is a breaking change, but it seems unlikely that this actually breaks code in the wild that wasn't already broken. I'll leave it up to T-lang to determine what is required here (crater run, FCW, ...), but my gut feeling is that we could just merge this and nobody would notice.

…=mejrs validate `#[link_name = "..."]` & `#[link(name = "...")]` parameters fixes rust-lang#155776 fixes rust-lang#155484 specifically, do not allow NULL bytes and the empty string in `#[link_name = "..."]` and `#[link(name = "...")]`. Like some of the others I think this formally needs to be looked at by T-lang because these errors would not show up if not linking. The LLVM erorr on `#[linke_name = "\0"]` is emitted here, it is not e.g. target-specific. https://github.com/llvm/llvm-project/blob/d593279c0b2891f0b0c8af3f70a1a0383b4ad1b5/llvm/lib/IR/Value.cpp#L336-L342 On `#[link(name = "")]` we already error today. A NULL byte in `#[link(name = "\0")]` is caught by the linker (https://godbolt.org/z/vnz9sYbPs), using `#[link_name = ""]` makes LLVM generate a name (https://godbolt.org/z/1hWEo4cxf) which is not useful and likely to cause linker errors. r? jdonszelmann

…acrum remove turbofish notation + use None / Some instead of Option:: (in match documentation)

…r=Mark-Simulacrum mark some panicking methods around Duration as track_caller Currently when they panic it looks like this ``` 0.005045 ---- instant_checked_duration_since_nopanic stdout ---- 0.000039 0.000009 thread 'instant_checked_duration_since_nopanic' (2) panicked at /home/runner/work/miri-test-libstd/miri-test-libstd/rust-src-patched/library/std/src/time.rs:445:33: 0.000007 overflow when subtracting duration from instant 0.000006 note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace 0.000007 note: in Miri, you may have to set `MIRIFLAGS=-Zmiri-env-forward=RUST_BACKTRACE` for the environment variable to have an effect ``` That's pretty useless. Also fix the panic message while we are at it.

JonathanBrouwer · 2026-05-09T18:53:30Z

@bors r+ rollup=never p=5

Trying commonly failed jobs
@bors try jobs=dist-various-1,test-various,x86_64-gnu-aux,x86_64-gnu-llvm-21-3,x86_64-msvc-1,aarch64-apple,x86_64-mingw-1,i686-msvc-2

rust-bors · 2026-05-09T18:53:32Z

📌 Commit f4cb666 has been approved by JonathanBrouwer

It is now in the queue for this repository.

Rollup of 11 pull requests try-job: dist-various-1 try-job: test-various try-job: x86_64-gnu-aux try-job: x86_64-gnu-llvm-21-3 try-job: x86_64-msvc-1 try-job: aarch64-apple try-job: x86_64-mingw-1 try-job: i686-msvc-2

rust-log-analyzer · 2026-05-09T20:05:03Z

The job aarch64-apple failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)


---- [debuginfo-lldb] tests/debuginfo/path.rs stdout ----
NOTE: compiletest thinks it is using LLDB version 1703

error: check directive(s) from `/Users/runner/work/rust/rust/tests/debuginfo/path.rs` not found in debugger output. errors:
    (path.rs:14) `[...] "/some/path" { data_ptr = [...] length = 10 }`
the following subset of check directive(s) was found successfully:
    (path.rs:10) `(std::path::PathBuf) "/some/path" { inner = "/some/path" { inner = { inner = size=10 { [0] = '/' [1] = 's' [2] = 'o' [3] = 'm' [4] = 'e' [5] = '/' [6] = 'p' [7] = 'a' [8] = 't' [9] = 'h' } } } } `
    (path.rs:12) `"/some/path" `
    (path.rs:16) `"/some/path" `
status: exit status: 0
command: LLDB_BATCHMODE_SCRIPT_PATH="/Users/runner/work/rust/rust/build/aarch64-apple-darwin/test/debuginfo/path.lldb/path.debugger.script" LLDB_BATCHMODE_TARGET_PATH="/Users/runner/work/rust/rust/build/aarch64-apple-darwin/test/debuginfo/path.lldb/a" PATH="/Users/runner/work/rust/rust/build/aarch64-apple-darwin/stage2/lib/rustlib/aarch64-apple-darwin/lib:/opt/homebrew/lib/ruby/gems/3.3.0/bin:/opt/homebrew/opt/ruby@3.3/bin:/Users/runner/.local/bin:/opt/homebrew/bin:/opt/homebrew/sbin:/Users/runner/.cargo/bin:/usr/local/opt/curl/bin:/usr/local/bin:/usr/local/sbin:/Users/runner/bin:/Users/runner/.yarn/bin:/Users/runner/Library/Android/sdk/tools:/Users/runner/Library/Android/sdk/platform-tools:/Library/Frameworks/Python.framework/Versions/Current/bin:/Library/Frameworks/Mono.framework/Versions/Current/Commands:/usr/bin:/bin:/usr/sbin:/sbin:/Users/runner/.dotnet/tools" PYTHONPATH="/Users/runner/work/rust/rust/src/etc" PYTHONUNBUFFERED="1" "lldb" "--one-line" "script --language python -- import lldb_batchmode; lldb_batchmode.main()"
--- stdout -------------------------------
(lldb) script --language python -- import lldb_batchmode; lldb_batchmode.main()
LLDB batch-mode script
----------------------
Debugger commands script is '/Users/runner/work/rust/rust/build/aarch64-apple-darwin/test/debuginfo/path.lldb/path.debugger.script'.
Target executable is '/Users/runner/work/rust/rust/build/aarch64-apple-darwin/test/debuginfo/path.lldb/a'.
Current working directory is '/Users/runner/work/rust/rust'
Creating a target for '/Users/runner/work/rust/rust/build/aarch64-apple-darwin/test/debuginfo/path.lldb/a'
settings set auto-confirm true

settings set target.inherit-tcc true

version
lldb-1703.0.236.21 Apple Swift version 6.2.3 (swiftlang-6.2.3.3.21 clang-1700.6.3.2) 
command script import /Users/runner/work/rust/rust/src/etc/lldb_lookup.py
# LLDB iterates through these in reverse order to discover summaries/synthetics that means the top
# of the list can be "overwritten" by items lower on the list. Be careful when reordering items.
# Forces test-compliant formatting to all other types
type synthetic add -l lldb_lookup.synthetic_lookup -x ".*" --category Rust
# Std String
type synthetic add -l lldb_lookup.StdStringSyntheticProvider -x "^(alloc::([a-z_]+::)+)String$" --category Rust
type summary add -F lldb_lookup.StdStringSummaryProvider -e -x -h "^(alloc::([a-z_]+::)+)String$" --category Rust
# Std str
type synthetic add -l lldb_lookup.StdSliceSyntheticProvider -x "^&(mut )?str$" --category Rust
type summary add -F lldb_lookup.StdStrSummaryProvider -e -x -h "^&(mut )?str$" --category Rust
## MSVC
type synthetic add -l lldb_lookup.MSVCStrSyntheticProvider -x "^ref(_mut)?\$<str\$>$" --category Rust
type summary add -F lldb_lookup.StdStrSummaryProvider -e -h -x "^ref(_mut)?\$<str\$>$" --category Rust
# Array/Slice
type synthetic add -l lldb_lookup.StdSliceSyntheticProvider -x "^&(mut )?\\[.+\\]$" --category Rust
type summary add -F lldb_lookup.SizeSummaryProvider -e -x -h "^&(mut )?\\[.+\\]$" --category Rust
## MSVC
type synthetic add -l lldb_lookup.MSVCStdSliceSyntheticProvider -x "^ref(_mut)?\$<slice2\$<.+> >" --category Rust
type summary add -F lldb_lookup.StdSliceSummaryProvider -e -x -h "^ref(_mut)?\$<slice2\$<.+> >" --category Rust
# OsString
type summary add -F lldb_lookup.StdOsStringSummaryProvider -e -x -h "^(std::ffi::([a-z_]+::)+)OsString$" --category Rust
# Vec
type synthetic add -l lldb_lookup.StdVecSyntheticProvider -x "^(alloc::([a-z_]+::)+)Vec<.+>$" --category Rust
type summary add -F lldb_lookup.SizeSummaryProvider -e -x -h "^(alloc::([a-z_]+::)+)Vec<.+>$" --category Rust
# VecDeque
type synthetic add -l lldb_lookup.StdVecDequeSyntheticProvider -x "^(alloc::([a-z_]+::)+)VecDeque<.+>$" --category Rust
type summary add -F lldb_lookup.SizeSummaryProvider -e -x -h "^(alloc::([a-z_]+::)+)VecDeque<.+>$" --category Rust
# HashMap
type synthetic add -l lldb_lookup.classify_hashmap -x "^(std::collections::([a-z_]+::)+)HashMap<.+>$" --category Rust
type summary add -F lldb_lookup.SizeSummaryProvider -e -x -h "^(std::collections::([a-z_]+::)+)HashMap<.+>$" --category Rust
# HashSet
type synthetic add -l lldb_lookup.classify_hashset -x "^(std::collections::([a-z_]+::)+)HashSet<.+>$" --category Rust
type summary add -F lldb_lookup.SizeSummaryProvider -e -x -h "^(std::collections::([a-z_]+::)+)HashSet<.+>$" --category Rust
# Rc
type synthetic add -l lldb_lookup.StdRcSyntheticProvider -x "^(alloc::([a-z_]+::)+)Rc<.+>$" --category Rust
type summary add -F lldb_lookup.StdRcSummaryProvider -e -x -h "^(alloc::([a-z_]+::)+)Rc<.+>$" --category Rust
# Arc
type synthetic add -l lldb_lookup.arc_synthetic -x "^(alloc::([a-z_]+::)+)Arc<.+>$" --category Rust
type summary add -F lldb_lookup.StdRcSummaryProvider -e -x -h "^(alloc::([a-z_]+::)+)Arc<.+>$" --category Rust
# Cell
type synthetic add -l lldb_lookup.StdCellSyntheticProvider -x "^(core::([a-z_]+::)+)Cell<.+>$" --category Rust
# RefCell
type synthetic add -l lldb_lookup.StdRefSyntheticProvider -x "^(core::([a-z_]+::)+)Ref(Cell|Mut)?<.+>$" --category Rust
type summary add -F lldb_lookup.StdRefSummaryProvider -e -x -h "^(core::([a-z_]+::)+)Ref(Cell|Mut)?<.+>$" --category Rust
# NonZero
type summary add -F lldb_lookup.StdNonZeroNumberSummaryProvider -e -x -h "^(core::([a-z_]+::)+)NonZero(<.+>|I\d{0,3}|U\d{0,3})$" --category Rust
# PathBuf
type summary add -F lldb_lookup.StdPathBufSummaryProvider -e -x -h "^(std::([a-z_]+::)+)PathBuf$" --category Rust
# Path
type summary add -F lldb_lookup.StdPathSummaryProvider -e -x -h "^&(mut )?(std::([a-z_]+::)+)Path$" --category Rust
# Enum
# type summary add -F lldb_lookup.ClangEncodedEnumSummaryProvider -e -h "lldb_lookup.is_sum_type_enum" --recognizer-function --category Rust
## MSVC
type synthetic add -l lldb_lookup.MSVCEnumSyntheticProvider -x "^enum2\$<.+>$" --category Rust
type summary add -F lldb_lookup.MSVCEnumSummaryProvider -e -x -h "^enum2\$<.+>$" --category Rust
## MSVC Variants
type synthetic add -l lldb_lookup.synthetic_lookup -x "^enum2\$<.+>::.*$" --category Rust
# Tuple
type synthetic add -l lldb_lookup.TupleSyntheticProvider -x "^\(.*\)$" --category Rust
type summary add -F lldb_lookup.TupleSummaryProvider -x "^\(.*\)$" --category Rust
## MSVC
type synthetic add -l lldb_lookup.MSVCTupleSyntheticProvider -x "^tuple\$<.+>$" --category Rust
type summary add -F lldb_lookup.TupleSummaryProvider -e -x -h "^tuple\$<.+>$" --category Rust
type category enable Rust

breakpoint set --file 'path.rs' --line 24
DEBUG: breakpoint added, id = 1
Breakpoint 1: where = a`path::main + 52 at path.rs:24:5, address = 0x000000010000096c 
DEBUG: registering breakpoint callback, id = 1
Error while trying to register breakpoint callback, id = 1, message = error: could not get num args: can't find callable: breakpoint_callback

run
Process 85092 launched: '/Users/runner/work/rust/rust/build/aarch64-apple-darwin/test/debuginfo/path.lldb/a' (arm64) Process 85092 stopped * thread #1, name = 'main', queue = 'com.apple.main-thread', stop reason = breakpoint 1.1 frame #0: 0x000000010000096c a`path::main at path.rs:24:5 21 let path = Path::new("/some/path"); 22 let pathbuf = path.to_path_buf(); 23 -> 24 zzz(); // #break ^ 25 } 26 27 fn zzz() { Target 0: (a) stopped. 
print pathbuf
(std::path::PathBuf) "/some/path" { inner = "/some/path" { inner = { inner = size=10 { [0] = '/' [1] = 's' [2] = 'o' [3] = 'm' [4] = 'e' [5] = '/' [6] = 'p' [7] = 'a' [8] = 't' [9] = 'h' } } } } 
po pathbuf
"/some/path" 
print path
(&std::path::Path) "some/pat" { data_ptr = 0x0000000100000b58 length = 10 } 
po path
"some/pat" 
quit
------------------------------------------
--- stderr -------------------------------
warning: This version of LLDB has no plugin for the language "rust". Inspection of frame variables will be limited.
------------------------------------------

---- [debuginfo-lldb] tests/debuginfo/path.rs stdout end ----

failures:

rust-bors · 2026-05-09T20:10:05Z

PR #155509, which is a member of this rollup, was unapproved.

This rollup was thus unapproved.

rust-bors · 2026-05-09T21:39:53Z

💔 Test for ab252f3 failed: CI. Failed job:

try - aarch64-apple (web logs, enhanced plaintext logs)

schneems and others added 25 commits March 2, 2026 14:42

Add Command::get_resolved_envs

5ed5b26

This addition allows an end-user to inspect the environment variables that are visible to the process when it boots.

add must_use tests for Result<MustUse/Struct, !>

25a1eb2

consider Result<T, !>/ControlFlow<!, T> the same as T for must_…

eb0d2a8

…use lint (or more accurately `Result<T, Uninhabited>`/`ControlFlow<Uninhabited, T>`). This generalizes a previous change where we only did this for `T = ()`.

remove dead code

4c4416b

error on empty export_name

d0ea88e

validate link name parameter

c08b9ab

specifically, do not allow NULL bytes and the empty string

Add regression test for issue 144329

fd2e542

gracefully handle invalid string/vec

e264a92

move string read logic to standalone function

0a4f89e

Update a bunch of bootstrap dependencies to remove windows-target

7eb6a20

remove turbofish notation + use None / Some instead of Option::

a80af22

mark some panicking methods around Duration as track_caller

09dc7fc

Add str::word_to_titlecase() to alloc

40da877

* Add `str::word_to_titlecase()` to `alloc` * Address review comment

Add mention of sendfile(2) and splice(2) to fs::copy() documentation.

f4adc40

* Add mention of sendfile(2) and splice(2) to fs::copy() documentation. * Oxford comma fix

Rollup merge of rust-lang#155705 - Jules-Bertholet:word-to-titlecase,…

f15f605

… r=Mark-Simulacrum Add `str::word_to_titlecase()` to `alloc` A small addition to rust-lang#153892. Hasn't gone through ACP, so needs libs-API signoff. @rustbot label A-Unicode T-libs-api

Rollup merge of rust-lang#155970 - tomilepp:issue-155968-fix, r=josht…

ec6e0ce

…riplett Add mention of sendfile(2) and splice(2) to fs::copy() documentation. Fixes rust-lang#155968 by adding mention of sendfile(2) and splice(2) from io::copy()

Rollup merge of rust-lang#156006 - bjorn3:bootstrap_no_import_libs, r…

4db2779

…=Mark-Simulacrum Update a bunch of bootstrap dependencies to remove windows-target Follow up to rust-lang#155444

Rollup merge of rust-lang#155188 - DaniPopes:144329-test, r=Mark-Simu…

65b5f57

…lacrum Add regression test for issue 144329 Closes rust-lang#144329.

Rollup merge of rust-lang#156107 - Cheese-Space:patch-1, r=Mark-Simul…

fb9735b

…acrum remove turbofish notation + use None / Some instead of Option:: (in match documentation)

rust-bors Bot added the rollup A PR which is a rollup label May 9, 2026

rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label May 9, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 9, 2026

This comment has been minimized.

Sign in to view

JonathanBrouwer mentioned this pull request May 9, 2026

[Debug Info] Gracefully handle invalid String/Vec #155509

Open

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 9, 2026

JonathanBrouwer closed this May 9, 2026

rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label May 9, 2026

rust-bors Bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label May 9, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 11 pull requests#156371

Rollup of 11 pull requests#156371
JonathanBrouwer wants to merge 25 commits intorust-lang:mainfrom
JonathanBrouwer:rollup-P4wIRmz

JonathanBrouwer commented May 9, 2026

Uh oh!

JonathanBrouwer commented May 9, 2026

Uh oh!

rust-bors Bot commented May 9, 2026

Uh oh!

This comment has been minimized.

rust-log-analyzer commented May 9, 2026

Uh oh!

rust-bors Bot commented May 9, 2026

Uh oh!

rust-bors Bot commented May 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

Uh oh!

Conversation

JonathanBrouwer commented May 9, 2026

Uh oh!

JonathanBrouwer commented May 9, 2026

Uh oh!

rust-bors Bot commented May 9, 2026

Uh oh!

This comment has been minimized.

rust-log-analyzer commented May 9, 2026

Uh oh!

rust-bors Bot commented May 9, 2026

Uh oh!

rust-bors Bot commented May 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants