[PERF CHECK ONLY] Add inline to trivial cross-crate accessors

[traviscross]

View all comments

Note

This is a draft for running perf.

Small accessor functions aren't inlined across crate boundaries in all build configurations. Even with LTO, PGO, etc., we may be limited in what gets inlined without these annotations.

In detailed profiling, the inline attributes being added in this PR seemed to make a difference. Let's add them.

Notably, some of these fall within the expansion of the newtype_index! macro and will apply to the items it defines.

r? @traviscross

[traviscross]

@bors try @rust-timer queue

[rust-bors]

☀️ Try build successful (CI)
Build commit: 6000502 (6000502f00011b1e462abca902ad51df79f2d675, parent: 8068e2fc9afa8c888336b12db01987be768785f9)

[rust-timer]

Finished benchmarking commit (6000502): comparison URL.

Overall result: ❌✅ regressions and improvements - please read:

Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf.

Next, please: If you can, justify the regressions found in this try perf run in writing along with @rustbot label: +perf-regression-triaged. If not, fix the regressions and do another perf run. Neutral or positive results will clear the label automatically.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	3.4%	[3.4%, 3.4%]	1
Regressions ❌ (secondary)	1.2%	[0.2%, 2.3%]	2
Improvements ✅ (primary)	-0.4%	[-0.6%, -0.1%]	11
Improvements ✅ (secondary)	-0.9%	[-1.0%, -0.8%]	6
All ❌✅ (primary)	-0.1%	[-0.6%, 3.4%]	12

Max RSS (memory usage)

Results (primary 1.4%, secondary 0.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.4%	[1.4%, 1.4%]	1
Regressions ❌ (secondary)	3.2%	[3.2%, 3.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.2%	[-2.2%, -2.2%]	1
All ❌✅ (primary)	1.4%	[1.4%, 1.4%]	1

Cycles

Results (secondary 2.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.8%	[2.8%, 2.8%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 498.048s -> 501.772s (0.75%)
Artifact size: 397.10 MiB -> 397.12 MiB (0.00%)

[traviscross]

@bors try @rust-timer queue

[traviscross]

@bors try @rust-timer queue

[rust-bors]

💔 Test for fa3d3ef failed: CI

[traviscross]

@bors try @rust-timer queue

[rust-bors]

☀️ Try build successful (CI)
Build commit: c51601b (c51601be0e9654351a230f76a0910211ce8897a9, parent: fb0a5a5a9c892b351f34263d6d84da9dde72871a)

[rust-timer]

Finished benchmarking commit (c51601b): comparison URL.

Overall result: ❌✅ regressions and improvements - please read:

Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf.

Next, please: If you can, justify the regressions found in this try perf run in writing along with @rustbot label: +perf-regression-triaged. If not, fix the regressions and do another perf run. Neutral or positive results will clear the label automatically.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	3.3%	[3.3%, 3.3%]	1
Regressions ❌ (secondary)	0.8%	[0.2%, 2.4%]	4
Improvements ✅ (primary)	-0.4%	[-0.6%, -0.2%]	14
Improvements ✅ (secondary)	-0.4%	[-1.1%, -0.1%]	20
All ❌✅ (primary)	-0.1%	[-0.6%, 3.3%]	15

Max RSS (memory usage)

Results (secondary 1.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.6%	[2.3%, 3.0%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.2%	[-3.2%, -3.2%]	1
All ❌✅ (primary)	-	-	0

Cycles

Results (primary -2.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.2%	[-2.2%, -2.2%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.2%	[-2.2%, -2.2%]	1

Binary size

Results (secondary -0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.1%	[-0.1%, -0.1%]	1
All ❌✅ (primary)	-	-	0

Bootstrap: 497.93s -> 502.373s (0.89%)
Artifact size: 397.14 MiB -> 396.95 MiB (-0.05%)

[traviscross]

@bors try parent=fb0a5a5a9c892b351f34263d6d84da9dde72871a @rust-timer queue

[rust-bors]

💔 Test for 2b7c262 failed: CI. Failed job:

• try - dist-x86_64-linux-quick (web logs, enhanced plaintext logs)

[traviscross]

@bors try parent=fb0a5a5a9c892b351f34263d6d84da9dde72871a @rust-timer queue

[traviscross]

@bors try cancel

[rust-bors]

Try build cancelled. Cancelled workflows:

• https://github.com/rust-lang/rust/actions/runs/25624771148

[traviscross]

@bors try parent=fb0a5a5a9c892b351f34263d6d84da9dde72871a @rust-timer queue

[rust-bors]

☀️ Try build successful (CI)
Build commit: 7da34a2 (7da34a22b8c1391c23c4d12a1da5e05ba47427d5, parent: fb0a5a5a9c892b351f34263d6d84da9dde72871a)

[traviscross]

@bors try parent=fb0a5a5a9c892b351f34263d6d84da9dde72871a @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[rust-bors]

⌛ Trying commit fdd8554 with merge 4a10250…

To cancel the try build, run the command @bors try cancel.

Workflow: https://github.com/rust-lang/rust/actions/runs/25628483189