Rollup of 10 pull requests#156278
Open
JonathanBrouwer wants to merge 24 commits intorust-lang:mainfrom
Open
Conversation
…g and OsString::into_string for you
Another user-transparent change, unifying outer-type information and the existing VisitorState flags.
In order to follow along with the efforts to properly distinguish already-normalised and unnormalized types, we separate the internal interfaces of this lint that rely on normalized types from those that do not. We do that by adding the `Unnormalized` wrapper to some interfaces.
CrateInfo is only necessary during linking and non-local LTO.
While it was previously defined in Session, it is only ever used with OutputFilenames methods.
Fixes LTO for `#![no_builtins]` crates with CFI enabled by using rustc's `EmitObj::Bitcode` path (and emitting LLVM bitcode in the `.o` for linker-based LTO).
There are quite a few.
There were fixed by rust-lang#140672
Another example from rust-lang/trait-system-refactor-initiative#139 and which was likely fixed by rust-lang#140672 as well.
Another example from rust-lang/trait-system-refactor-initiative#139 and which was fixed in 1.89 `nightly-2025-06-18`.
…, r=petrochenkov lint ImproperCTypes: refactor linting architecture (part 2) This is the second PR in an effort to split rust-lang#134697 (refactor plus overhaul of the ImproperCTypes family of lints) into individually-mergeable parts. Contains the changes of the first PR, and splits the core type checking function into several bits, each focused on a specific aspect of FFI-safety. Some logic which was outside of said core function was also moved into the new functions. Superset of: rust-lang#146271
Add `keepalive`, `set_keepalive` to `TcpStream` implementations ## What The current implementation of `TcpStream` does not expose `SO_KEEPALIVE`: rust-lang#69774 ## Why It seems the reason this has not yet been implemented is because the initial implementation went as far as to take the keepalive interval as a parameter. However, Windows does not directly expose these intervals for reading, causing there to be some debate about the shape of the API (see the discussion of this [here](rust-lang#31945 (comment))). ## How I am proposing that this API is enabled with a `bool` parameter to align with the implementation in both Windows and Unix, as it is the least common denominator between the two of them. With regards to the call to `setsockopt`, [Windows expects a disable/enable](https://learn.microsoft.com/en-us/windows/win32/winsock/so-keepalive), and [Unix does as well](https://man7.org/linux/man-pages/man7/socket.7.html). The extra configuration for Unix that allows the interval to be tweaked could be done through an additional API perhaps, but I don't think that's stopping us from exposing the switch to at least enable the behavior with the OS defaults. Tracking issue: rust-lang#155889
CFI: Fix LTO for `#![no_builtins]` crates with CFI Fixes LTO for `#![no_builtins]` crates with CFI enabled by using rustc's `EmitObj::Bitcode` path (and emitting LLVM bitcode in the `.o` for linker-based LTO). It also adds tests that verify that the examples in [rust-cfi-examples](https://github.com/rcvalle/rust-cfi-examples) build and run with `-Zbuild-std` to prevent other future regressions.
Move CrateInfo computation after codegen_crate CrateInfo is only necessary during linking and non-local LTO. Part of rust-lang/compiler-team#908
Add better default spans for the `Ty` impl of `QueryKey` This add default spans for `Ty` in its implementation of `QueryKey`. This is useful so we can get spans for the `layout_of` query which shows up in cycle errors.
…s-cg-clif, r=bjorn3 cg_clif: Don't show verbose run-make cmd output for passing tests Uses `--verbose-run-make-subprocess-output=false` added in rust-lang#154587 to suppress verbose cmd dump for passing `run-make` tests. Closes rust-lang#154069.
…ia-e Implemented `PathBuf::into_string` Noticed from this [Zulip chat](https://rust-lang.zulipchat.com/#narrow/channel/327149-t-libs-api.2Fapi-changes/topic/.E2.9C.94.20PathBuf.3A.3Ainto_string.3F/with/500962843) that there's been a pretty old [ACP](rust-lang/libs-team#307) on introducing `PathBuf::into_string` that hasn't been implemented yet. I haven't seen anyone link a tracking issue to that [ACP](rust-lang/libs-team#307), so I assume there have been no PRs to complete that ACP. I made a tracking issue for this ACP [here](rust-lang#156203).
…-obk Move invocation_temp into OutputFilenames While it was previously defined in Session, it is only ever used with OutputFilenames methods.
add a few new solver normalization tests As discussed [on zulip](https://rust-lang.zulipchat.com/#narrow/channel/364551-t-types.2Ftrait-system-refactor/topic/ask.20for.20help/near/593097133), this PR adds the handful of new solver revisions and tests from rust-lang/trait-system-refactor-initiative#139. Most cases that issue mentions were already fixed by rust-lang#140672 in 1.88, and some cases, we expect, by rust-lang#155767. The issue about defaulted type parameters applies to both solvers and will be tracked in rust-lang#156271 instead. Closes rust-lang/trait-system-refactor-initiative#139. r? lcnr I'm not sure where the best place for the tests would be, do you have a better location in mind?
…Key-impls, r=mejrs Remove unused `ToStableHashKey` impls. There are quite a few. r? @mejrs
rustbot
added
A-LLVM
rustbot
added
the
T-libs
Contributor
Author
Contributor
rust-bors
Bot
added
S-waiting-on-bors
Contributor
|
⌛ Trying commit c19565b with merge ea5c46c… To cancel the try build, run the command Workflow: https://github.com/rust-lang/rust/actions/runs/25495111512 |
rust-bors Bot
pushed a commit
that referenced
this pull request
May 7, 2026
Rollup of 10 pull requests try-job: dist-various-1 try-job: test-various try-job: x86_64-gnu-aux try-job: x86_64-gnu-llvm-21-3 try-job: x86_64-msvc-1 try-job: aarch64-apple try-job: x86_64-mingw-1 try-job: i686-msvc-2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
keepalive,set_keepalivetoTcpStreamimplementations #154025 (Addkeepalive,set_keepalivetoTcpStreamimplementations)#![no_builtins]crates with CFI #156024 (CFI: Fix LTO for#![no_builtins]crates with CFI)Tyimpl ofQueryKey#154846 (Add better default spans for theTyimpl ofQueryKey)PathBuf::into_string#156204 (ImplementedPathBuf::into_string)ToStableHashKeyimpls. #156265 (Remove unusedToStableHashKeyimpls.)r? @ghost
Create a similar rollup