Skip to content

Rollup of 5 pull requests#156275

Closed
JonathanBrouwer wants to merge 11 commits intorust-lang:mainfrom
JonathanBrouwer:rollup-0kXfHjm
Closed

Rollup of 5 pull requests#156275
JonathanBrouwer wants to merge 11 commits intorust-lang:mainfrom
JonathanBrouwer:rollup-0kXfHjm

Conversation

@JonathanBrouwer
Copy link
Copy Markdown
Contributor

@JonathanBrouwer JonathanBrouwer commented May 7, 2026

Successful merges:

r? @ghost

Create a similar rollup

niacdoial and others added 11 commits May 5, 2026 23:59
@niacdoial
ImproperCTypes: merge outer_ty information into VisitorState
411a932 
Another user-transparent change, unifying outer-type information and the
existing VisitorState flags.
@niacdoial
ImproperCTypes: Use more Unnormalized type wrappers
6839797 
In order to follow along with the efforts to properly distinguish
already-normalised and unnormalized types, we separate the internal
interfaces of this lint that rely on normalized types from those that
do not. We do that by adding the `Unnormalized` wrapper to some
interfaces.
@bjorn3
Move CrateInfo computation after codegen_crate
da6e4d4 
CrateInfo is only necessary during linking and non-local LTO.
@bjorn3
Move invocation_temp into OutputFilenames
9297586 
While it was previously defined in Session, it is only ever used with
OutputFilenames methods.
@rcvalle
CFI: Fix LTO for #![no_builtins] crates with CFI
acc33fe 
Fixes LTO for `#![no_builtins]` crates with CFI enabled by using rustc's
`EmitObj::Bitcode` path (and emitting LLVM bitcode in the `.o` for
linker-based LTO).
@nnethercote
Remove unused ToStableHashKey impls.
769f2f1 
There are quite a few.
@JonathanBrouwer
Rollup merge of rust-lang#146273 - niacdoial:improperctypes-refactor2…
5c05531 
…, r=petrochenkov

lint ImproperCTypes: refactor linting architecture (part 2)

This is the second PR in an effort to split rust-lang#134697 (refactor plus overhaul of the ImproperCTypes family of lints) into individually-mergeable parts.

Contains the changes of the first PR, and splits the core type checking function into several bits, each focused on a specific aspect of FFI-safety.
Some logic which was outside of said core function was also moved into the new functions.

Superset of: rust-lang#146271
@JonathanBrouwer
Rollup merge of rust-lang#156024 - rcvalle:rust-cfi-fix-142284, r=bjorn3
53219be 
CFI: Fix LTO for `#![no_builtins]` crates with CFI

Fixes LTO for `#![no_builtins]` crates with CFI enabled by using rustc's `EmitObj::Bitcode` path (and emitting LLVM bitcode in the `.o` for linker-based LTO).

It also adds tests that verify that the examples in [rust-cfi-examples](https://github.com/rcvalle/rust-cfi-examples) build and run with `-Zbuild-std` to prevent other future regressions.
@JonathanBrouwer
Rollup merge of rust-lang#156243 - bjorn3:lto_refactors18, r=mu001999
c59758f 
Move CrateInfo computation after codegen_crate

CrateInfo is only necessary during linking and non-local LTO.

Part of rust-lang/compiler-team#908
@JonathanBrouwer
Rollup merge of rust-lang#156245 - bjorn3:move_invocation_temp, r=oli…
c91a5ef 
…-obk

Move invocation_temp into OutputFilenames

While it was previously defined in Session, it is only ever used with OutputFilenames methods.
@JonathanBrouwer
Rollup merge of rust-lang#156265 - nnethercote:rm-unused-ToStableHash…
a23541d 
…Key-impls, r=mejrs

Remove unused `ToStableHashKey` impls.

There are quite a few.

r? @mejrs
@rust-bors rust-bors Bot added the rollup A PR which is a rollup label May 7, 2026
@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 7, 2026
@JonathanBrouwer
Copy link
Copy Markdown
Contributor Author

JonathanBrouwer commented May 7, 2026

@bors r+ rollup=never p=5

Trying commonly failed jobs
@bors try jobs=dist-various-1,test-various,x86_64-gnu-aux,x86_64-gnu-llvm-21-3,x86_64-msvc-1,aarch64-apple,x86_64-mingw-1,i686-msvc-2

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented May 7, 2026

📌 Commit a23541d has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 7, 2026
@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request May 7, 2026
@bors
Auto merge of #156275 - JonathanBrouwer:rollup-0kXfHjm, r=<try>
ec7d689 
Rollup of 5 pull requests


try-job: dist-various-1
try-job: test-various
try-job: x86_64-gnu-aux
try-job: x86_64-gnu-llvm-21-3
try-job: x86_64-msvc-1
try-job: aarch64-apple
try-job: x86_64-mingw-1
try-job: i686-msvc-2
@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request May 7, 2026
@bors
Auto merge of #156275 - JonathanBrouwer:rollup-0kXfHjm, r=JonathanBro…
fc4b52a 
…uwer

Rollup of 5 pull requests

Successful merges:

 - #146273 (lint ImproperCTypes: refactor linting architecture (part 2))
 - #156024 (CFI: Fix LTO for `#![no_builtins]` crates with CFI)
 - #156243 (Move CrateInfo computation after codegen_crate)
 - #156245 (Move invocation_temp into OutputFilenames)
 - #156265 (Remove unused `ToStableHashKey` impls.)
@rust-log-analyzer
Copy link
Copy Markdown
Collaborator

rust-log-analyzer commented May 7, 2026

The job x86_64-gnu-llvm-21-1 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
test expr_store::scope::tests::test_shadow_variable ... ok
test expr_store::tests::body::array_element_cfg ... ok
test expr_store::tests::body::block::inner_item_smoke ... ok
test expr_store::scope::tests::while_let_adds_binding ... ok
error: test failed, to rerun pass `-p hir-def --lib`

Caused by:
  process didn't exit successfully: `/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/hir_def-c439368f2b64a049 '--skip=tests::smoke_test_real_sysroot_cargo' --skip=check_code_formatting -Z unstable-options --format json` (signal: 11, SIGSEGV: invalid memory reference)
Bootstrap failed while executing `--stage 2 test --skip tests --skip coverage-map --skip coverage-run --skip library --skip tidyselftest`
Build completed unsuccessfully in 1:06:40
  local time: Thu May  7 11:50:11 UTC 2026
  network time: Thu, 07 May 2026 11:50:11 GMT
##[error]Process completed with exit code 1.

@rust-bors rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 7, 2026
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented May 7, 2026

💔 Test for fc4b52a failed: CI. Failed job:

@lqd
Copy link
Copy Markdown
Member

lqd commented May 7, 2026

another r-a segfault it seems

@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 7, 2026
@rust-bors rust-bors Bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label May 7, 2026
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented May 7, 2026

This pull request was unapproved due to being closed.

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented May 7, 2026

☀️ Try build successful (CI)
Build commit: ec7d689 (ec7d689adc35e2f1c304c173d70f6e4425fe0822, parent: 0e5924a4a0b57f2c6bc8cac93f59281e68541a91)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-run-make Area: port run-make Makefiles to rmake.rs rollup A PR which is a rollup S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@JonathanBrouwer @rust-log-analyzer @lqd @rustbot @niacdoial @bjorn3 @rcvalle @nnethercote