resolve: Remove `MacroData` by petrochenkov · Pull Request #156236 · rust-lang/rust

petrochenkov · 2026-05-06T11:42:21Z

All the necessary data can be taken from SyntaxExtension instead.

rustbot · 2026-05-06T11:42:25Z

rustbot has assigned @chenyukang.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 73 candidates
Random selection from 18 candidates

chenyukang · 2026-05-06T15:30:55Z

@bors r=chenyukang

rust-bors · 2026-05-06T15:30:58Z

📌 Commit feec99d has been approved by chenyukang

It is now in the queue for this repository.

…uwer Rollup of 7 pull requests Successful merges: - #146273 (lint ImproperCTypes: refactor linting architecture (part 2)) - #149509 (Lint unused pub items in binary crates) - #156173 (Fewer global node_id_to_def_id lookups) - #155961 (Deny warnings in the test for crates that are available on stable) - #156130 (Fold/visit tweaks) - #156131 (Metadata macro/query cleanups) - #156202 (llvm: Use correct type for splat mask) Failed merges: - #156236 (resolve: Remove `MacroData`)

resolve: Remove `MacroData` All the necessary data can be taken from `SyntaxExtension` instead.

…uwer Rollup of 3 pull requests Successful merges: - #156061 (Support `-Cpanic=unwind` on WASI targets) - #156236 (resolve: Remove `MacroData`) - #155981 (Use special DefIds for aliases)

…uwer Rollup of 9 pull requests Successful merges: - #156061 (Support `-Cpanic=unwind` on WASI targets) - #146273 (lint ImproperCTypes: refactor linting architecture (part 2)) - #149509 (Lint unused pub items in binary crates) - #156173 (Fewer global node_id_to_def_id lookups) - #155961 (Deny warnings in the test for crates that are available on stable) - #155981 (Use special DefIds for aliases) - #156130 (Fold/visit tweaks) - #156131 (Metadata macro/query cleanups) - #156202 (llvm: Use correct type for splat mask) Failed merges: - #156236 (resolve: Remove `MacroData`)

resolve: Remove `MacroData` All the necessary data can be taken from `SyntaxExtension` instead.

petrochenkov · 2026-05-07T13:57:41Z

Rebased and added one more related commit.
@rustbot ready

All the necessary data can be taken from `SyntaxExtension` instead.

Clone only on interface boundaries with `rustc_expand`

rustbot · 2026-05-07T17:27:08Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

chenyukang · 2026-05-08T07:29:15Z

@bors r=chenyukang

rust-bors · 2026-05-08T07:29:18Z

📌 Commit 503960c has been approved by chenyukang

It is now in the queue for this repository.

rust-bors · 2026-05-08T08:12:32Z

⌛ Testing commit 503960c with merge 52ebe86...

Workflow: https://github.com/rust-lang/rust/actions/runs/25544847480

resolve: Remove `MacroData` All the necessary data can be taken from `SyntaxExtension` instead.

JonathanBrouwer · 2026-05-08T08:20:16Z

@bors yield
Yielding to enclosing rollup

rust-bors · 2026-05-08T08:20:20Z

Auto build was cancelled. Cancelled workflows:

https://github.com/rust-lang/rust/actions/runs/25544847480

The next pull request likely to be tested is #156303.

…uwer Rollup of 3 pull requests Successful merges: - #156236 (resolve: Remove `MacroData`) - #156298 (Rename the unstable integer `extend` function to `widen`) - #156214 (Do not cache `lints_that_dont_need_to_run` across sessions)

rust-bors · 2026-05-08T09:33:52Z

⌛ Testing commit 503960c with merge ab28d28...

Workflow: https://github.com/rust-lang/rust/actions/runs/25548303246

resolve: Remove `MacroData` All the necessary data can be taken from `SyntaxExtension` instead.

JonathanBrouwer · 2026-05-08T09:35:55Z

@bors yield
Yielding to enclosing rollup

rust-bors · 2026-05-08T09:36:05Z

Auto build was cancelled. Cancelled workflows:

https://github.com/rust-lang/rust/actions/runs/25548303246

The next pull request likely to be tested is #156305.

…uwer Rollup of 7 pull requests Successful merges: - #156236 (resolve: Remove `MacroData`) - #156298 (Rename the unstable integer `extend` function to `widen`) - #154498 (turn some long-deprecated -C options into errors) - #155734 (Reject outer attributes on `cfg_select` branches) - #156123 (Simplify the creation of synthetic HIR.) - #156175 (Dep graph cleanups) - #156214 (Do not cache `lints_that_dont_need_to_run` across sessions)

rust-bors · 2026-05-08T10:49:27Z

⌛ Testing commit 503960c with merge 2f301e1...

Workflow: https://github.com/rust-lang/rust/actions/runs/25551502062

resolve: Remove `MacroData` All the necessary data can be taken from `SyntaxExtension` instead.

JonathanBrouwer · 2026-05-08T11:06:59Z

@bors yield
Yielding to enclosing rollup

rust-bors · 2026-05-08T11:07:03Z

Auto build was cancelled. Cancelled workflows:

https://github.com/rust-lang/rust/actions/runs/25551502062

The next pull request likely to be tested is #156305.

…uwer Rollup of 7 pull requests Successful merges: - #156236 (resolve: Remove `MacroData`) - #156298 (Rename the unstable integer `extend` function to `widen`) - #154498 (turn some long-deprecated -C options into errors) - #155734 (Reject outer attributes on `cfg_select` branches) - #156123 (Simplify the creation of synthetic HIR.) - #156175 (Dep graph cleanups) - #156214 (Do not cache `lints_that_dont_need_to_run` across sessions)

rustbot assigned chenyukang May 6, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 6, 2026

petrochenkov mentioned this pull request May 6, 2026

Don't return dummy MacroData in get_macro #156151

Merged

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 6, 2026

JonathanBrouwer mentioned this pull request May 6, 2026

Rollup of 7 pull requests #156249

Closed

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request May 6, 2026

Rollup merge of rust-lang#156236 - petrochenkov:nomacdata, r=chenyukang

9c2d328

resolve: Remove `MacroData` All the necessary data can be taken from `SyntaxExtension` instead.

JonathanBrouwer mentioned this pull request May 6, 2026

Rollup of 3 pull requests #156253

Closed

JonathanBrouwer mentioned this pull request May 6, 2026

Rollup of 9 pull requests #156254

Closed

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request May 6, 2026

Rollup merge of rust-lang#156236 - petrochenkov:nomacdata, r=chenyukang

9749f01

resolve: Remove `MacroData` All the necessary data can be taken from `SyntaxExtension` instead.

JonathanBrouwer mentioned this pull request May 6, 2026

Rollup of 3 pull requests #156255

Closed

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 7, 2026

This comment has been minimized.

Sign in to view

petrochenkov force-pushed the nomacdata branch from feec99d to 4ba935b Compare May 7, 2026 13:57

This comment has been minimized.

Sign in to view

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 7, 2026

This comment has been minimized.

Sign in to view

This comment was marked as outdated.

Sign in to view

petrochenkov added 2 commits May 7, 2026 20:23

resolve: Remove MacroData

c834e9f

All the necessary data can be taken from `SyntaxExtension` instead.

resolve: Avoid some Arc cloning with syntax extensions

503960c

Clone only on interface boundaries with `rustc_expand`

petrochenkov force-pushed the nomacdata branch from 4ba935b to 503960c Compare May 7, 2026 17:27

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 8, 2026

rust-bors Bot pushed a commit that referenced this pull request May 8, 2026

Auto merge of #156236 - petrochenkov:nomacdata, r=chenyukang

52ebe86

resolve: Remove `MacroData` All the necessary data can be taken from `SyntaxExtension` instead.

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request May 8, 2026

Rollup merge of rust-lang#156236 - petrochenkov:nomacdata, r=chenyukang

a9fb2b8

resolve: Remove `MacroData` All the necessary data can be taken from `SyntaxExtension` instead.

JonathanBrouwer mentioned this pull request May 8, 2026

Rollup of 3 pull requests #156303

Closed

rust-bors Bot pushed a commit that referenced this pull request May 8, 2026

Auto merge of #156236 - petrochenkov:nomacdata, r=chenyukang

ab28d28

resolve: Remove `MacroData` All the necessary data can be taken from `SyntaxExtension` instead.

JonathanBrouwer mentioned this pull request May 8, 2026

Rollup of 7 pull requests #156305

Merged

rust-bors Bot pushed a commit that referenced this pull request May 8, 2026

Auto merge of #156236 - petrochenkov:nomacdata, r=chenyukang

2f301e1

resolve: Remove `MacroData` All the necessary data can be taken from `SyntaxExtension` instead.

rust-bors Bot merged commit abafa65 into rust-lang:main May 8, 2026
11 of 12 checks passed

rustbot added this to the 1.97.0 milestone May 8, 2026

Uh oh!

Conversation

petrochenkov commented May 6, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented May 6, 2026

Uh oh!

chenyukang commented May 6, 2026

Uh oh!

rust-bors Bot commented May 6, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

petrochenkov commented May 7, 2026

Uh oh!

This comment has been minimized.

This comment was marked as outdated.

rustbot commented May 7, 2026

Uh oh!

chenyukang commented May 8, 2026

Uh oh!

rust-bors Bot commented May 8, 2026

Uh oh!

rust-bors Bot commented May 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JonathanBrouwer commented May 8, 2026

Uh oh!

rust-bors Bot commented May 8, 2026

Uh oh!

rust-bors Bot commented May 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JonathanBrouwer commented May 8, 2026

Uh oh!

rust-bors Bot commented May 8, 2026

Uh oh!

rust-bors Bot commented May 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JonathanBrouwer commented May 8, 2026

Uh oh!

rust-bors Bot commented May 8, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

petrochenkov commented May 6, 2026 •

edited by rustbot

Loading

rust-bors Bot commented May 8, 2026 •

edited

Loading

rust-bors Bot commented May 8, 2026 •

edited

Loading

rust-bors Bot commented May 8, 2026 •

edited

Loading