Resolve some cases of #132279 by using the right typing mode in the next solver#156141
Open
jdonszelmann wants to merge 3 commits intorust-lang:mainfrom
Open
Resolve some cases of #132279 by using the right typing mode in the next solver#156141jdonszelmann wants to merge 3 commits intorust-lang:mainfrom
jdonszelmann wants to merge 3 commits intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-author
jdonszelmann
force-pushed
the
use-right-typingmode
branch
3 times, most recently
from
c4406f0 to
bac5eb5
Compare
jdonszelmann
force-pushed
the
use-right-typingmode
branch
from
bac5eb5 to
7d76533
Compare
Collaborator
|
Some changes occurred to constck cc @fee1-dead Some changes occurred to the CTFE machinery |
rustbot
added
S-waiting-on-review
lcnr
reviewed
May 4, 2026
Comment on lines
103
to
105
| // FIXME(#132279): Once we've got a typing mode which reveals opaque types using the HIR | ||
| // typeck results without causing query cycles, we should use this here instead of defining | ||
| // opaque types. |
Contributor
There was a problem hiding this comment.
do remove the fixme please
| } | ||
| } else { | ||
| match self.phase { | ||
| // FIXME(#132279): we should reveal the opaques defined in the body during analysis. |
Contributor
There was a problem hiding this comment.
I think that fixme can also be removed 🤷 there's nothing actionable here
Comment on lines
+324
to
+328
| // Defuse the drop bomb in the OpaqueTypeStorage when we're in TypingMode::Borrowck, | ||
| // and the InferCtxt doesn't consider regions. This is okay since in `Borrowck`, | ||
| // the only reason we care about opaques is in relation to regions. | ||
| // In some places *after* typeck, like in lints we use `TypingMode::Borrowck` | ||
| // to prevent defining opaque types and we simply don't care about regions. |
Contributor
There was a problem hiding this comment.
want to move the Drop check the opaque_type_storage to here and remove that impl, having the handling of this assert split over 2 impls feels suboptimal
Contributor
|
@rustbot author |
rustbot
added
S-waiting-on-author
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @lcnr
Convert 3 FIXMEs of #132279 to using the right typing mode when we can (
tcx.use_typing_mode_borrowck())Also resolves #155093, which I closed