Added command-line argument support for `wasm32-wali-linux-musl` by arjunr2 · Pull Request #156062 · rust-lang/rust

arjunr2 · 2026-05-01T20:31:13Z

No description provided.

rustbot · 2026-05-01T20:31:17Z

rustbot has assigned @nia-e.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: @ChrisDenton, libs
@ChrisDenton, libs expanded to 8 candidates
Random selection from Mark-Simulacrum, jhpratt, nia-e

nia-e

Looks good modulo one nitpick, thanks!

View changes since this review

nia-e · 2026-05-01T21:56:14Z

+            CString::from_raw(ptr)
+        };
+        let mut arg_buf = arg_buf.into_bytes_with_nul();
+        let _ = arg_buf.pop();


Why not just use CString::into_bytes directly?

arjunr2 · 2026-05-04T12:35:40Z

@rustbot ready

nia-e · 2026-05-04T12:59:31Z

@bors r+

rust-bors · 2026-05-04T12:59:34Z

📌 Commit f4e1b2f has been approved by nia-e

It is now in the queue for this repository.

Added command-line argument support for `wasm32-wali-linux-musl`

…uwer Rollup of 10 pull requests Successful merges: - #155848 ([doc]: Revert `core::io::ErrorKind` doc changes) - #155855 (Remove unnecessary `get_unchecked`) - #156062 (Added command-line argument support for `wasm32-wali-linux-musl`) - #155543 (docs(unstable-book): Document const generics features) - #156043 (c-variadic: gate `va_arg` on `c_variadic_experimental_arch`) - #156082 (Move tests associated types) - #156092 (Clean up `TyCtxt::needs_crate_hash` usage and rename it to `needs_hir_hash`.) - #156104 (Relax `T: Sized` bound on `try_as_dyn` / `try_as_dyn_mut`) - #156128 (.mailmap: prefer matching just based on commit emails) - #156135 (Remove most uses of def_id_to_node_id)

JonathanBrouwer · 2026-05-04T17:18:12Z

@bors r-
#156150 (comment)

rust-bors · 2026-05-04T17:18:20Z

This pull request was unapproved.

This PR was contained in a rollup (#156150), which was unapproved.

View changes since this unapproval

nia-e · 2026-05-05T15:56:51Z

Will merge if this passes, but just to be safe

@bors try

Added command-line argument support for `wasm32-wali-linux-musl`

rust-bors · 2026-05-05T18:06:02Z

☀️ Try build successful (CI)
Build commit: aafe03d (aafe03dd4fad788bd4316633148b3ef2500fac1d, parent: 4feb7221f4d445120a5061b16ce7222adbfdf6f6)

JonathanBrouwer · 2026-05-05T19:20:06Z

I think you meant
@bors try jobs=dist-various-1

Added command-line argument support for `wasm32-wali-linux-musl` try-job: dist-various-1

nia-e · 2026-05-05T20:37:08Z

@bors r+

rust-bors · 2026-05-05T20:37:11Z

📌 Commit 9ef7541 has been approved by nia-e

It is now in the queue for this repository.

rust-bors · 2026-05-05T20:42:28Z

☀️ Try build successful (CI)
Build commit: b3e6164 (b3e6164eb7727c8122a99a5fba611376b39eef60, parent: 4feb7221f4d445120a5061b16ce7222adbfdf6f6)

Added command-line argument support for `wasm32-wali-linux-musl`

Rollup of 12 pull requests Successful merges: - #155341 (generic_const_args: allow paths to non type consts) - #156062 (Added command-line argument support for `wasm32-wali-linux-musl`) - #156159 ([AIX] add -bdbg:namedsects:ss link arg) - #156174 (Wasm: remove implicit `__heap_base`/`__data_end` exports) - #156186 (fix: remap ci-llvm debug paths via `-ffile-prefix-map`) - #156193 (port `rustc_ast*` crates from `box_` to `deref_patterns`) - #156201 (Don't run ui-fulldeps tests twice in stage 1) - #155808 (Always use `ConstFn` context for `const` closures) - #156105 (interpret: correctly deal with repr(transparent) enums) - #156148 (Use `all_impls` instead of handrolling it) - #156156 (Adjust getMCSubtargetInfo signature for LLVM 23+) - #156205 (move generalization test)

Rollup of 15 pull requests Successful merges: - #151122 (fix: more descriptive error message for enum to integer) - #155341 (generic_const_args: allow paths to non type consts) - #156062 (Added command-line argument support for `wasm32-wali-linux-musl`) - #156159 ([AIX] add -bdbg:namedsects:ss link arg) - #156174 (Wasm: remove implicit `__heap_base`/`__data_end` exports) - #156186 (fix: remap ci-llvm debug paths via `-ffile-prefix-map`) - #156193 (port `rustc_ast*` crates from `box_` to `deref_patterns`) - #156201 (Don't run ui-fulldeps tests twice in stage 1) - #155808 (Always use `ConstFn` context for `const` closures) - #156105 (interpret: correctly deal with repr(transparent) enums) - #156148 (Use `all_impls` instead of handrolling it) - #156156 (Adjust getMCSubtargetInfo signature for LLVM 23+) - #156170 (add known-bug test for coroutine 'static-yields-non-'static unsoundness (#144442)) - #156195 (Move tests codegen) - #156205 (move generalization test)

Rollup merge of #156062 - arjunr2:wali-support-clargs, r=nia-e Added command-line argument support for `wasm32-wali-linux-musl`

Added std library support for WALI command-line arguments.

a1c5893

rustbot assigned nia-e May 1, 2026

rustbot added O-linux Operating system: Linux S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 1, 2026

rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label May 1, 2026

nia-e reviewed May 1, 2026

View reviewed changes

nia-e added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 1, 2026

Use into_bytes directly

f4e1b2f

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 4, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 4, 2026

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request May 4, 2026

Rollup merge of rust-lang#156062 - arjunr2:wali-support-clargs, r=nia-e

0824adf

Added command-line argument support for `wasm32-wali-linux-musl`

JonathanBrouwer mentioned this pull request May 4, 2026

Rollup of 9 pull requests #156149

Closed

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request May 4, 2026

Rollup merge of rust-lang#156062 - arjunr2:wali-support-clargs, r=nia-e

4ba7b13

Added command-line argument support for `wasm32-wali-linux-musl`

JonathanBrouwer mentioned this pull request May 4, 2026

Rollup of 10 pull requests #156150

Closed

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 4, 2026

Restrict cfg gating on unix to not interfere with emscripten target

9ef7541

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request May 5, 2026

Auto merge of #156062 - arjunr2:wali-support-clargs, r=<try>

aafe03d

Added command-line argument support for `wasm32-wali-linux-musl`

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request May 5, 2026

Auto merge of #156062 - arjunr2:wali-support-clargs, r=<try>

b3e6164

Added command-line argument support for `wasm32-wali-linux-musl` try-job: dist-various-1

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 5, 2026

jhpratt added a commit to jhpratt/rust that referenced this pull request May 5, 2026

Rollup merge of rust-lang#156062 - arjunr2:wali-support-clargs, r=nia-e

c7c62db

Added command-line argument support for `wasm32-wali-linux-musl`

jhpratt mentioned this pull request May 5, 2026

Rollup of 12 pull requests #156207

Closed

jhpratt added a commit to jhpratt/rust that referenced this pull request May 5, 2026

Rollup merge of rust-lang#156062 - arjunr2:wali-support-clargs, r=nia-e

5f43c56

Added command-line argument support for `wasm32-wali-linux-musl`

jhpratt mentioned this pull request May 5, 2026

Rollup of 12 pull requests #156213

Closed

jhpratt mentioned this pull request May 6, 2026

Rollup of 15 pull requests #156217

Merged

rust-bors Bot merged commit 0092af0 into rust-lang:main May 6, 2026
12 checks passed

rustbot added this to the 1.97.0 milestone May 6, 2026

rust-timer added a commit that referenced this pull request May 6, 2026

Unrolled build for #156062

5b80f19

Rollup merge of #156062 - arjunr2:wali-support-clargs, r=nia-e Added command-line argument support for `wasm32-wali-linux-musl`

Uh oh!

Conversation

arjunr2 commented May 1, 2026

Uh oh!

rustbot commented May 1, 2026

Uh oh!

nia-e left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nia-e May 1, 2026

Choose a reason for hiding this comment

Uh oh!

arjunr2 commented May 4, 2026

Uh oh!

nia-e commented May 4, 2026

Uh oh!

rust-bors Bot commented May 4, 2026

Uh oh!

JonathanBrouwer commented May 4, 2026

Uh oh!

rust-bors Bot commented May 4, 2026

Uh oh!

nia-e commented May 5, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented May 5, 2026

Uh oh!

JonathanBrouwer commented May 5, 2026

Uh oh!

This comment has been minimized.

nia-e commented May 5, 2026

Uh oh!

rust-bors Bot commented May 5, 2026

Uh oh!

rust-bors Bot commented May 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

nia-e left a comment •

edited by rustbot

Loading