Skip to content

Rollup of 5 pull requests#155918

Closed
jhpratt wants to merge 12 commits intorust-lang:mainfrom
jhpratt:rollup-61d5ugT
Closed

Rollup of 5 pull requests#155918
jhpratt wants to merge 12 commits intorust-lang:mainfrom
jhpratt:rollup-61d5ugT

Conversation

@jhpratt
Copy link
Copy Markdown
Member

@jhpratt jhpratt commented Apr 28, 2026

Successful merges:

r? @ghost

Create a similar rollup

zetanumbers and others added 12 commits April 14, 2026 11:43
@zetanumbers
Lock stable_crate_ids once in create_crate_num
438d886
@WeiTheShinobi
Tweak irrefutable let else warning output, add new suggestion
8591f0f
@arjunr2
Update documentation for wasm32-wali-linux-musl after integrating n…
3c362ec 
…ew LLVM 22 `wasm32-linux-muslwali` target changes
@arjunr2
Add specific target diffs
c20757f
@fneddy @folkertdev
Add --print=backend-has-mnemonic and needs-asm-mnemonic directive
2a8e588 
Add infrastructure to query LLVM backend for specific assembly mnemonics
and use it in compiletest to conditionally run tests based on instruction
availability.

This fixes test failures with naked-dead-code-elimination which requires
the `RET` mnemonic.

Co-authored-by: Folkert de Vries <flokkievids@gmail.com>
@oli-obk
Add regression test for hkl const closures
4d4058b
@oli-obk
Handle hkl const closures
b465c56
@jhpratt
Rollup merge of rust-lang#154325 - WeiTheShinobi:tweak-let-else-outpu…
1c5a113 
…t, r=davidtwco

Tweak irrefutable let else warning output

Fixes rust-lang#153454

Greeting!
This PR tweak diagnostic output for `irrefutable-let-else` patterns and adds a check for `let a = Some(b) else {...}`
Thanks for the review!

```
help: consider using `let Some(name) = case` to match on a specific variant
   |
LL -     let name = Some(case) else {
LL +     let Some(name) = case else {
   |
```
@jhpratt
Rollup merge of rust-lang#155273 - zetanumbers:create_crate_num_lock,…
4e6f062 
… r=jdonszelmann

Lock stable_crate_ids once in create_crate_num

This is a small refactor PR removing redundant locks of `stable_crate_ids` from  `create_crate_num`.
@jhpratt
Rollup merge of rust-lang#155692 - fneddy:fix_naked-dead-code-elimina…
56b7504 
…tion, r=folkertdev

disable naked-dead-code-elimination test if no RET mnemonic is available

this test emit x86_64 specific ret asm instruction and should not be compiled on any other arch.
@jhpratt
Rollup merge of rust-lang#155747 - arjunr2:main, r=davidtwco
064d3ee 
Update documentation for `wasm32-wali-linux-musl` after integrating n…

Additional documentation updates, along with rust-lang#155654
@jhpratt
Rollup merge of rust-lang#155907 - oli-obk:push-nypowoyskzxp, r=Kivooeo
8463b3a 
Handle hkl const closures

I severely overthought this in rust-lang#153818 😆

The const closure trait solver impl is now in sync with the non-const closure trait solver impl.
@rust-bors rust-bors Bot added the rollup A PR which is a rollup label Apr 28, 2026
@rustbot rustbot added A-compiletest Area: The compiletest test runner A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-run-make Area: port run-make Makefiles to rmake.rs A-rustc-dev-guide Area: rustc-dev-guide A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 28, 2026
@jhpratt
Copy link
Copy Markdown
Member Author

jhpratt commented Apr 28, 2026

@bors r+ rollup=never p=5

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Apr 28, 2026

📌 Commit 8463b3a has been approved by jhpratt

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 28, 2026
@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Apr 28, 2026
@bors
Auto merge of #155918 - jhpratt:rollup-61d5ugT, r=jhpratt
4e3ce91 
Rollup of 5 pull requests

Successful merges:

 - #154325 (Tweak irrefutable let else warning output)
 - #155273 (Lock stable_crate_ids once in create_crate_num)
 - #155692 (disable naked-dead-code-elimination test if no RET mnemonic is available)
 - #155747 (Update documentation for `wasm32-wali-linux-musl` after integrating n…)
 - #155907 (Handle hkl const closures)
@rust-bors rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 28, 2026
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Apr 28, 2026

💔 Test for 4e3ce91 failed: CI. Failed job:

@rust-log-analyzer
Copy link
Copy Markdown
Collaborator

rust-log-analyzer commented Apr 28, 2026

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
##[endgroup]
Image input checksum 8808edb3604b1e929c1d2316d5912ca04329fa4b79e352f54c4425ff2e75e3d082c6d57477973c2148874869471a5a7aa49b7e66acae5d358298ea79ea409354
##[group]Building docker image for x86_64-gnu-llvm-22
Docker version 28.0.4, build b8034c0
Error response from daemon: Get "https://ghcr.io/v2/": Get "https://ghcr.io/token?account=rust-lang&client_id=docker&offline_token=true&service=ghcr.io": net/http: request canceled (Client.Timeout exceeded while awaiting headers) (Client.Timeout exceeded while awaiting headers)
##[error]Process completed with exit code 1.
##[group]Run echo "disk usage:"
echo "disk usage:"
df -h
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}

@JonathanBrouwer
Copy link
Copy Markdown
Contributor

JonathanBrouwer commented Apr 28, 2026

Spurious

@rust-bors rust-bors Bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Apr 28, 2026
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 28, 2026
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Apr 28, 2026

This pull request was unapproved due to being closed.

@jhpratt jhpratt deleted the rollup-61d5ugT branch April 28, 2026 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-compiletest Area: The compiletest test runner A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-run-make Area: port run-make Makefiles to rmake.rs A-rustc-dev-guide Area: rustc-dev-guide A-testsuite Area: The testsuite used to check the correctness of rustc rollup A PR which is a rollup S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@jhpratt @rust-log-analyzer @JonathanBrouwer @rustbot @zetanumbers @WeiTheShinobi @arjunr2 @fneddy @oli-obk