Check arguments of attributes where no arguments are expected

[JonathanBrouwer]

View all comments

This PR does the following:

• Add a debug assertion to rustc_attr_parsing, to ensure we never forget to check the arguments of a meta item again
• Removes the unused #[derive(Clone)] from ArgParser as that would break this debug assertion
• [BREAKING] Properly check that #[inline(always(...))] gets no arguments
• [BREAKING] Properly check that #[instruction_set(arm::a32(...))] gets no arguments
• [BREAKING] Properly check that #[macro_export(local_inner_macros(...))] gets no arguments.
  Fixes Invalid value accepted for #[macro_export(local_inner_macros)] #154977
• [BREAKING] Properly check that #[used(compiler(...))] gets no arguments.
• Properly check that #[optimize(size(...))] gets no arguments.
• Properly check that #[coverage(on(...))] gets no arguments.
• Properly check that #[rustc_dump_layout(debug(...))] gets no arguments.
• Properly check that #[rustc_abi(debug(...))] gets no arguments.
• Properly check that #![test_runner(arg(...))] gets no arguments.
• Properly check that #[rustc_must_implement_one_of(arg(...))] gets no arguments.
• Properly check that #[allow_internal_unstable(arg(...))] gets no arguments.
• Properly check that #[unstable_feature_bound(arg(...))] gets no arguments.
• Properly check that #[rustc_allow_const_fn_unstable(arg(...))] gets no arguments.
• Properly check that #[rustc_if_this_changed(arg(...))] gets no arguments.
• Properly check that #[rustc_then_this_would_need(arg(...))] gets no arguments.

r? @jdonszelmann

[rustbot]

⚠️ #[rustc_allow_const_fn_unstable] needs careful audit to avoid accidentally exposing unstable
implementation details on stable.

cc @rust-lang/wg-const-eval

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

[JonathanBrouwer]

@bors try

[JonathanBrouwer]

@bors try cancel
@bors try

[rust-bors]

Try build cancelled. Cancelled workflows:

• https://github.com/rust-lang/rust/actions/runs/24305234582

[rust-bors]

☀️ Try build successful (CI)
Build commit: b98202a (b98202ad067d72e45cec8be3d5c15d86ef0fd086, parent: 540f43a224317d894a9a0710a8d67704f179a33c)

[JonathanBrouwer]

@craterbot check

[craterbot]

👌 Experiment pr-155193 created and queued.
🤖 Automatically detected try build b98202a
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[JonathanBrouwer]

11 regressed and 2 fixed are spurious.
1 regression is real, spectest-0.1.2 uses the incorrect #[inline(always = true)] syntax. The bug that allowed this is not recent (i.e. not introduced by the new parsing infrastructure) and has existed for years

Given that there is breakage, let's ask for T-lang approval: @rust-lang/lang

Given that this is quite a niche crate, I propose to make a PR to this crate and accept the breakage.

[JonathanBrouwer]

PR submitted to spectest: aalexandrov/spectest#1

[jdonszelmann]

minor changes

View changes since this review

[rustbot]

Reminder, once the PR becomes ready for a review, use @rustbot ready.

[JonathanBrouwer]

@rustbot ready