Skip to content

Add const_param_ty_unchecked gate#153536

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
zedddie:const-param-ty-unchecked-gate
May 3, 2026
Merged

Add const_param_ty_unchecked gate#153536
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
zedddie:const-param-ty-unchecked-gate

Conversation

@zedddie
Copy link
Copy Markdown
Contributor

@zedddie zedddie commented Mar 7, 2026 •
edited by rustbot
Loading

View all comments

Add const_param_ty_unchecked internal feature gate to skip ConstParamTy_ trait enforcement on type. Provides an escape hatch for writing tests and examples that use const generics without needing to ensure all fields implement ConstParamTy_.

r? BoxyUwU

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 7, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Mar 7, 2026

BoxyUwU is currently at their maximum review capacity.
They may take a while to respond.

BoxyUwU
BoxyUwU reviewed Mar 16, 2026
View reviewed changes
Comment thread compiler/rustc_hir_analysis/src/coherence/builtin.rs
@zedddie zedddie force-pushed the const-param-ty-unchecked-gate branch from 6dbf494 to 758baed Compare March 22, 2026 18:56
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Mar 22, 2026

changes to the core type system

cc @lcnr

@rustbot

This comment has been minimized.

Sign in to view
zedddie
zedddie commented Mar 22, 2026
View reviewed changes
Comment thread compiler/rustc_hir_analysis/src/coherence/builtin.rs
BoxyUwU
BoxyUwU reviewed Mar 23, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@BoxyUwU BoxyUwU left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx yeah this is what i was looking for :3

View changes since this review

Comment thread compiler/rustc_hir_analysis/src/check/wfcheck.rs Outdated
Comment thread compiler/rustc_hir_analysis/src/check/wfcheck.rs Outdated
Comment thread compiler/rustc_hir_analysis/src/coherence/builtin.rs
Comment thread compiler/rustc_trait_selection/src/traits/wf.rs
Comment thread tests/ui/const-generics/adt_const_params/const_param_ty_unchecked.rs Outdated
@zedddie zedddie force-pushed the const-param-ty-unchecked-gate branch from 758baed to 38f2b3e Compare March 28, 2026 02:05
@rust-bors

This comment has been minimized.

Sign in to view
@zedddie zedddie force-pushed the const-param-ty-unchecked-gate branch from 38f2b3e to 335585b Compare April 7, 2026 17:43
@rustbot

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@zedddie
Copy link
Copy Markdown
Contributor Author

zedddie commented Apr 7, 2026 •
edited
Loading

its fine locally... :_<

@BoxyUwU BoxyUwU closed this Apr 10, 2026
@BoxyUwU BoxyUwU reopened this Apr 10, 2026
@BoxyUwU
Copy link
Copy Markdown
Member

BoxyUwU commented Apr 10, 2026

retriggering CI 🤔

@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 10, 2026
@fmease fmease added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 13, 2026
@BoxyUwU
Copy link
Copy Markdown
Member

BoxyUwU commented Apr 14, 2026

@bors r+

thank you :)

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Apr 14, 2026

📌 Commit 335585b has been approved by BoxyUwU

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 14, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Apr 14, 2026
@JonathanBrouwer
Rollup merge of rust-lang#153536 - zedddie:const-param-ty-unchecked-g…
80b14a2 
…ate, r=BoxyUwU

Add `const_param_ty_unchecked` gate

Add `const_param_ty_unchecked` internal feature gate to skip `ConstParamTy_` trait enforcement on type. Provides an escape hatch for writing tests and examples that use const generics without needing to ensure all fields implement `ConstParamTy_`.

r? BoxyUwU
@JonathanBrouwer JonathanBrouwer mentioned this pull request Apr 14, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Apr 14, 2026
@JonathanBrouwer
Rollup merge of rust-lang#153536 - zedddie:const-param-ty-unchecked-g…
c5c1d2c 
…ate, r=BoxyUwU

Add `const_param_ty_unchecked` gate

Add `const_param_ty_unchecked` internal feature gate to skip `ConstParamTy_` trait enforcement on type. Provides an escape hatch for writing tests and examples that use const generics without needing to ensure all fields implement `ConstParamTy_`.

r? BoxyUwU
@JonathanBrouwer JonathanBrouwer mentioned this pull request Apr 14, 2026
Closed
rust-bors Bot pushed a commit that referenced this pull request Apr 14, 2026
@bors
Auto merge of #155309 - JonathanBrouwer:rollup-jdUZekM, r=JonathanBro…
9c8ebe4 
…uwer

Rollup of 9 pull requests

Successful merges:

 - #153536 (Add `const_param_ty_unchecked` gate)
 - #153815 (Fix ICE when Self is used in enum discriminant of a generic enum)
 - #154882 (Gate tuple const params behind `min_adt_const_params` feature)
 - #155293 (fix arch names in cfg pretty printer)
 - #154765 (Clarify ascii whitespace exclusion of vertical tab in the doc)
 - #155172 (Some small nits for supertrait_item_shadowing, and additional testing)
 - #155279 (Test/lexer unicode pattern white space)
 - #155280 (Tests for precise-capture through RPIT and TAIT)
 - #155304 (remove PointeeParser)
@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Apr 15, 2026
@bors
Auto merge of #153536 - zedddie:const-param-ty-unchecked-gate, r=BoxyUwU
e151184 
Add `const_param_ty_unchecked` gate

Add `const_param_ty_unchecked` internal feature gate to skip `ConstParamTy_` trait enforcement on type. Provides an escape hatch for writing tests and examples that use const generics without needing to ensure all fields implement `ConstParamTy_`.

r? BoxyUwU
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-bors rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 15, 2026
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Apr 15, 2026

💔 Test for e151184 failed: CI. Failed job:

@JonathanBrouwer
Copy link
Copy Markdown
Contributor

JonathanBrouwer commented Apr 15, 2026

@bors r-
#155309

@rust-bors rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 15, 2026
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Apr 15, 2026

This PR was contained in a rollup (#155309), which was unapproved.

@zedddie zedddie force-pushed the const-param-ty-unchecked-gate branch from 335585b to 35bc543 Compare April 21, 2026 19:31
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 21, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@BoxyUwU
Copy link
Copy Markdown
Member

BoxyUwU commented May 3, 2026

@bors r+

whoops forgot about this because it was waiting on author

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented May 3, 2026

📌 Commit 35bc543 has been approved by BoxyUwU

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 3, 2026
@JonathanBrouwer JonathanBrouwer mentioned this pull request May 3, 2026
Merged
rust-bors Bot pushed a commit that referenced this pull request May 3, 2026
@bors
Auto merge of #156113 - JonathanBrouwer:rollup-yXpNY1L, r=JonathanBro…
ad3a598 
…uwer

Rollup of 3 pull requests

Successful merges:

 - #153536 (Add `const_param_ty_unchecked` gate)
 - #155528 (const-stabilize `char::is_control()`)
 - #156086 (VaList::next_arg: track_caller for better Miri errors)
@rust-bors rust-bors Bot merged commit 43fbdfd into rust-lang:main May 3, 2026
11 checks passed
@rustbot rustbot added this to the 1.97.0 milestone May 3, 2026
rust-timer added a commit that referenced this pull request May 3, 2026
@rust-timer
Unrolled build for #153536
065d619 
Rollup merge of #153536 - zedddie:const-param-ty-unchecked-gate, r=BoxyUwU

Add `const_param_ty_unchecked` gate

Add `const_param_ty_unchecked` internal feature gate to skip `ConstParamTy_` trait enforcement on type. Provides an escape hatch for writing tests and examples that use const generics without needing to ensure all fields implement `ConstParamTy_`.

r? BoxyUwU
github-actions Bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request May 4, 2026
@bors
Auto merge of #156113 - JonathanBrouwer:rollup-yXpNY1L, r=JonathanBro…
bf351c1 
…uwer

Rollup of 3 pull requests

Successful merges:

 - rust-lang/rust#153536 (Add `const_param_ty_unchecked` gate)
 - rust-lang/rust#155528 (const-stabilize `char::is_control()`)
 - rust-lang/rust#156086 (VaList::next_arg: track_caller for better Miri errors)
pull Bot pushed a commit to xtqqczze/rust-lang-miri that referenced this pull request May 4, 2026
@bors
Auto merge of #156113 - JonathanBrouwer:rollup-yXpNY1L, r=JonathanBro…
e8d11f3 
…uwer

Rollup of 3 pull requests

Successful merges:

 - rust-lang/rust#153536 (Add `const_param_ty_unchecked` gate)
 - rust-lang/rust#155528 (const-stabilize `char::is_control()`)
 - rust-lang/rust#156086 (VaList::next_arg: track_caller for better Miri errors)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BoxyUwU BoxyUwU BoxyUwU left review comments

Assignees

@BoxyUwU BoxyUwU

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.97.0

Development

Successfully merging this pull request may close these issues.

6 participants

@zedddie @rustbot @rust-log-analyzer @BoxyUwU @JonathanBrouwer @fmease