Skip to content

Navigation Menu

Appearance settings

View all features
- BY COMPANY SIZE
  Enterprises
  Small and medium teams
  Startups
  Nonprofits
- BY USE CASE
  App Modernization
  DevSecOps
  DevOps
  CI/CD
  View all use cases
- BY INDUSTRY
  Healthcare
  Financial services
  Manufacturing
  Government
  View all industries
View all solutions
- EXPLORE BY TOPIC
  AI
  Software Development
  DevOps
  Security
  View all topics
- EXPLORE BY TYPE
  Customer stories
  Events & webinars
  Ebooks & reports
  Business insights
  GitHub Skills
- SUPPORT & SERVICES
  Documentation
  Customer support
  Community forum
  Trust center
  Partners
View all resources
- COMMUNITY
  GitHub SponsorsFund open source developers
- PROGRAMS
  Security Lab
  Maintainer Community
  Accelerator
  GitHub Stars
  Archive Program
- REPOSITORIES
  Topics
  Trending
  Collections
- ENTERPRISE SOLUTIONS
  Enterprise platformAI-powered developer platform
- AVAILABLE ADD-ONS
  GitHub Advanced SecurityEnterprise-grade security features
  Copilot for BusinessEnterprise-grade AI features
  Premium SupportEnterprise-grade 24/7 support
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

Appearance settings

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

rust-lang / rust Public

Notifications You must be signed in to change notification settings
Fork 14.9k
Star 113k

Code
Issues 5k+
Pull requests 1.1k
Actions
Projects
Security and quality 6
Insights

Additional navigation options

Code
Issues
Pull requests
Actions
Projects
Security and quality
Insights

Improve diagnostic output of `non_local_definitions` lint#125089

Merged

bors merged 11 commits into

rust-lang:masterrust-lang/rust:masterfrom

Urgau:non_local_def-suggestionsUrgau/rust:non_local_def-suggestionsCopy head branch name to clipboard

May 28, 2024

Conversation Commits11 (11)Checks Files changed

Merged

Improve diagnostic output of `non_local_definitions` lint#125089
bors merged 11 commits into
rust-lang:masterfrom
Urgau:non_local_def-suggestions

Commits

Commits on May 27, 2024

non_local_defs: move out from `#[derive(LintDiagnostic)]` to manual impl
Urgau
committed
non_local_defs: switch to more friendly primary message
Urgau
committed
non_local_defs: improve some notes around trait, bounds, consts
Urgau
committed
non_local_defs: use span of the impl def and not the impl block
Urgau
committed
non_local_defs: use labels to indicate what may need to be moved
Urgau
committed
non_local_defs: improve exception note for impl and macro_rules!
Urgau
committed
non_local_defs: be more precise about what needs to be moved
Urgau
committed
non_local_defs: improve main without a trait note
Urgau
committed
non_local_defs: suggest removing leading ref/ptr to make the impl local
Urgau
committed
non_local_defs: point to Self and Trait to give more context
Urgau
committed
non_local_defs: point the parent item when appropriate
Urgau
committed

Footer

© 2026 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Community
Docs
Contact

You can’t perform that action at this time.