Auto merge of #155380 - jhpratt:rollup-j1e7DVL, r=jhpratt

Rollup of 18 pull requests

Successful merges:

 - #154451 (Require that a `<_ as Try>::Residual` implement the `Residual` trait)
 - #154595 (Emit fatal on invalid const args with nested defs)
 - #154599 (report the `varargs_without_pattern` lint in deps)
 - #154699 (`core::unicode`: Replace `Cased` table with `Lt`)
 - #155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field)
 - #155357 (Add `--remap-path-scope` as unstable in rustdoc)
 - #150649 (clippy fix: non_canonical_clone_impl)
 - #154604 (abort in core)
 - #154616 (Add `--quiet` flag to x.py and bootstrap to suppress output)
 - #155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting)
 - #155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions)
 - #155266 (Adjust release notes for post-merge feedback)
 - #155326 (Disallow ZST allocations with `TypedArena`.)
 - #155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests)
 - #155340 (Handle nonnull pattern types in size skeleton)
 - #155347 (Add push_mut and new Layout methods to release notes)
 - #155356 (remove calls to AliasTyKind::def_id)
 - #155364 (Reduce diagnostic type visibilities.)

Author: bors

tests/ui/manual_try_fold.rs

@@ -2,24 +2,31 @@
 #![allow(clippy::unnecessary_fold, unused)]
 #![warn(clippy::manual_try_fold)]
 #![feature(try_trait_v2)]
+#![feature(try_trait_v2_residual)]
 //@no-rustfix
-use std::ops::{ControlFlow, FromResidual, Try};
+use std::ops::{ControlFlow, FromResidual, Residual, Try};
 
 #[macro_use]
 extern crate proc_macros;
 
 // Test custom `Try` with more than 1 argument
 struct NotOption(i32, i32);
 
+struct NotOptionResidual;
+
 impl<R> FromResidual<R> for NotOption {
     fn from_residual(_: R) -> Self {
         todo!()
     }
 }
 
+impl Residual<()> for NotOptionResidual {
+    type TryType = NotOption;
+}
+
 impl Try for NotOption {
     type Output = ();
-    type Residual = ();
+    type Residual = NotOptionResidual;
 
     fn from_output(_: Self::Output) -> Self {
         todo!()
@@ -34,15 +41,21 @@ impl Try for NotOption {
 #[derive(Default)]
 struct NotOptionButWorse(i32);
 
+struct NotOptionButWorseResidual;
+
 impl<R> FromResidual<R> for NotOptionButWorse {
     fn from_residual(_: R) -> Self {
         todo!()
     }
 }
 
+impl Residual<()> for NotOptionButWorseResidual {
+    type TryType = NotOptionButWorse;
+}
+
 impl Try for NotOptionButWorse {
     type Output = ();
-    type Residual = ();
+    type Residual = NotOptionButWorseResidual;
 
     fn from_output(_: Self::Output) -> Self {
         todo!()

tests/ui/manual_try_fold.stderr

@@ -1,5 +1,5 @@
 error: usage of `Iterator::fold` on a type that implements `Try`
-  --> tests/ui/manual_try_fold.rs:59:10
+  --> tests/ui/manual_try_fold.rs:72:10
    |
 LL |         .fold(Some(0i32), |sum, i| sum?.checked_add(*i))
    |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `try_fold` instead: `try_fold(0i32, |sum, i| ...)`
@@ -8,19 +8,19 @@ LL |         .fold(Some(0i32), |sum, i| sum?.checked_add(*i))
    = help: to override `-D warnings` add `#[allow(clippy::manual_try_fold)]`
 
 error: usage of `Iterator::fold` on a type that implements `Try`
-  --> tests/ui/manual_try_fold.rs:64:10
+  --> tests/ui/manual_try_fold.rs:77:10
    |
 LL |         .fold(NotOption(0i32, 0i32), |sum, i| NotOption(0i32, 0i32));
    |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `try_fold` instead: `try_fold(..., |sum, i| ...)`
 
 error: usage of `Iterator::fold` on a type that implements `Try`
-  --> tests/ui/manual_try_fold.rs:68:10
+  --> tests/ui/manual_try_fold.rs:81:10
    |
 LL |         .fold(NotOptionButWorse(0i32), |sum, i| NotOptionButWorse(0i32));
    |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `try_fold` instead: `try_fold(0i32, |sum, i| ...)`
 
 error: usage of `Iterator::fold` on a type that implements `Try`
-  --> tests/ui/manual_try_fold.rs:99:10
+  --> tests/ui/manual_try_fold.rs:112:10
    |
 LL |         .fold(Some(0i32), |sum, i| sum?.checked_add(*i))
    |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `try_fold` instead: `try_fold(0i32, |sum, i| ...)`