Make span_suggestions always verbose

`span_suggestions` is to provide mutually exclusive suggestions. When it was introduced, we made its behavior be that if a single suggestion is given to it, we present the suggestion inline, otherwise in patch format. Changing this to make all of its uses be verbose, as that is closer in intent of output.

Author: estebank

tests/ui/blocks_in_conditions.stderr

@@ -29,10 +29,15 @@ error: this boolean expression can be simplified
   --> tests/ui/blocks_in_conditions.rs:48:8
    |
 LL |     if true && x == 3 { 6 } else { 10 }
-   |        ^^^^^^^^^^^^^^ help: try: `x == 3`
+   |        ^^^^^^^^^^^^^^
    |
    = note: `-D clippy::nonminimal-bool` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::nonminimal_bool)]`
+help: try
+   |
+LL -     if true && x == 3 { 6 } else { 10 }
+LL +     if x == 3 { 6 } else { 10 }
+   |
 
 error: aborting due to 3 previous errors
 

tests/ui/crashes/ice-96721.stderr

@@ -2,9 +2,14 @@ error: malformed `path` attribute input
   --> tests/ui/crashes/ice-96721.rs:7:1
    |
 LL | #[path = foo!()]
-   | ^^^^^^^^^^^^^^^^ help: must be of the form: `#[path = "file"]`
+   | ^^^^^^^^^^^^^^^^
    |
    = note: for more information, visit <https://doc.rust-lang.org/reference/items/modules.html#the-path-attribute>
+help: must be of the form
+   |
+LL - #[path = foo!()]
+LL + #[path = "file"]
+   |
 
 error: aborting due to 1 previous error
 

tests/ui/nonminimal_bool.stderr

@@ -2,46 +2,87 @@ error: this boolean expression can be simplified
   --> tests/ui/nonminimal_bool.rs:17:13
    |
 LL |     let _ = !true;
-   |             ^^^^^ help: try: `false`
+   |             ^^^^^
    |
    = note: `-D clippy::nonminimal-bool` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::nonminimal_bool)]`
+help: try
+   |
+LL -     let _ = !true;
+LL +     let _ = false;
+   |
 
 error: this boolean expression can be simplified
   --> tests/ui/nonminimal_bool.rs:20:13
    |
 LL |     let _ = !false;
-   |             ^^^^^^ help: try: `true`
+   |             ^^^^^^
+   |
+help: try
+   |
+LL -     let _ = !false;
+LL +     let _ = true;
+   |
 
 error: this boolean expression can be simplified
   --> tests/ui/nonminimal_bool.rs:23:13
    |
 LL |     let _ = !!a;
-   |             ^^^ help: try: `a`
+   |             ^^^
+   |
+help: try
+   |
+LL -     let _ = !!a;
+LL +     let _ = a;
+   |
 
 error: this boolean expression can be simplified
   --> tests/ui/nonminimal_bool.rs:26:13
    |
 LL |     let _ = false || a;
-   |             ^^^^^^^^^^ help: try: `a`
+   |             ^^^^^^^^^^
+   |
+help: try
+   |
+LL -     let _ = false || a;
+LL +     let _ = a;
+   |
 
 error: this boolean expression can be simplified
   --> tests/ui/nonminimal_bool.rs:32:13
    |
 LL |     let _ = !(!a && b);
-   |             ^^^^^^^^^^ help: try: `a || !b`
+   |             ^^^^^^^^^^
+   |
+help: try
+   |
+LL -     let _ = !(!a && b);
+LL +     let _ = a || !b;
+   |
 
 error: this boolean expression can be simplified
   --> tests/ui/nonminimal_bool.rs:35:13
    |
 LL |     let _ = !(!a || b);
-   |             ^^^^^^^^^^ help: try: `a && !b`
+   |             ^^^^^^^^^^
+   |
+help: try
+   |
+LL -     let _ = !(!a || b);
+LL +     let _ = a && !b;
+   |
 
 error: this boolean expression can be simplified
   --> tests/ui/nonminimal_bool.rs:38:13
    |
 LL |     let _ = !a && !(b && c);
-   |             ^^^^^^^^^^^^^^^ help: try: `!(a || b && c)`
+   |             ^^^^^^^^^^^^^^^
+   |
+help: try
+   |
+LL -     let _ = !a && !(b && c);
+LL +     let _ = !(a || b && c);
+   |
 
 error: this boolean expression can be simplified
   --> tests/ui/nonminimal_bool.rs:47:13
@@ -122,7 +163,13 @@ error: this boolean expression can be simplified
   --> tests/ui/nonminimal_bool.rs:90:8
    |
 LL |     if matches!(true, true) && true {
-   |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `matches!(true, true)`
+   |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+   |
+help: try
+   |
+LL -     if matches!(true, true) && true {
+LL +     if matches!(true, true) {
+   |
 
 error: this boolean expression can be simplified
   --> tests/ui/nonminimal_bool.rs:171:8
@@ -215,13 +262,25 @@ error: this boolean expression can be simplified
   --> tests/ui/nonminimal_bool.rs:212:8
    |
 LL |     if !(a < 2.0 && !b) {
-   |        ^^^^^^^^^^^^^^^^ help: try: `a >= 2.0 || b`
+   |        ^^^^^^^^^^^^^^^^
+   |
+help: try
+   |
+LL -     if !(a < 2.0 && !b) {
+LL +     if a >= 2.0 || b {
+   |
 
 error: this boolean expression can be simplified
   --> tests/ui/nonminimal_bool.rs:231:12
    |
 LL |         if !(matches!(ty, TyKind::Ref(_, _, _)) && !is_mutable(&expr)) {
-   |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!matches!(ty, TyKind::Ref(_, _, _)) || is_mutable(&expr)`
+   |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+   |
+help: try
+   |
+LL -         if !(matches!(ty, TyKind::Ref(_, _, _)) && !is_mutable(&expr)) {
+LL +         if !matches!(ty, TyKind::Ref(_, _, _)) || is_mutable(&expr) {
+   |
 
 error: this boolean expression can be simplified
   --> tests/ui/nonminimal_bool.rs:251:8

tests/ui/nonminimal_bool_methods.stderr

@@ -29,13 +29,25 @@ error: this boolean expression can be simplified
   --> tests/ui/nonminimal_bool_methods.rs:20:13
    |
 LL |     let _ = !(a.is_some() && !c);
-   |             ^^^^^^^^^^^^^^^^^^^^ help: try: `a.is_none() || c`
+   |             ^^^^^^^^^^^^^^^^^^^^
+   |
+help: try
+   |
+LL -     let _ = !(a.is_some() && !c);
+LL +     let _ = a.is_none() || c;
+   |
 
 error: this boolean expression can be simplified
   --> tests/ui/nonminimal_bool_methods.rs:22:13
    |
 LL |     let _ = !(a.is_some() || !c);
-   |             ^^^^^^^^^^^^^^^^^^^^ help: try: `a.is_none() && c`
+   |             ^^^^^^^^^^^^^^^^^^^^
+   |
+help: try
+   |
+LL -     let _ = !(a.is_some() || !c);
+LL +     let _ = a.is_none() && c;
+   |
 
 error: this boolean expression can be simplified
   --> tests/ui/nonminimal_bool_methods.rs:24:26