[WIP][DNM] Switch to GitHub Actions by flip1995 · Pull Request #5071 · rust-lang/rust-clippy

flip1995 · 2020-01-20T15:08:15Z

This is just an experiment. I don't think we have a consensus if we should move away from travis/appveyor.

GHA would let us run up to 20 concurrent jobs. Since we have 15 integration tests and 4 (linux, linux 32-bit, macos, windows) basic tests, we would be able to run everything concurrently. ~~Also IIUC we only have to build Clippy once for every initegration test and then only check the repos.~~ Nope, dependent jobs exist, but they won't keep the artifacts (not even the checkout).

TODO before merge:

Add DEPLOY_KEY secret to github repo
test deployment on test branch gh-test
talk with @rust-lang/infra for bors
Add GHA badge to Cargo.toml (blocked on Support GitHub Actions Badges crates.io#1838)
Add back travis + appveyor files for transition period (?)

changelog: none

flip1995 · 2020-01-20T15:08:29Z

@bors try

bors · 2020-01-20T15:08:36Z

⌛ Trying commit 4a261de with merge 887982f...

[WIP][DNM] Switch to GitHub Actions (maybe?) cc #4577 This is just an experiment. I don't think we have a consensus _if_ we should move away from travis/appveyor. changelog: none

flip1995 · 2020-01-20T15:09:02Z

^ This should run integration tests through GHA.

flip1995 · 2020-01-20T15:34:04Z

@bors try

[WIP][DNM] Switch to GitHub Actions (maybe?) cc #4577 This is just an experiment. I don't think we have a consensus _if_ we should move away from travis/appveyor. GHA would let us run up to 20 concurrent jobs. Since we have 15 integration tests and 4 (linux, linux 32-bit, macos, windows) basic tests, we would be able to run everything concurrently. Also IIUC we only have to build Clippy once for every initegration test and then only check the repos. changelog: none

bors · 2020-01-20T15:34:23Z

⌛ Trying commit 16b3e3c with merge 673554f...

flip1995 · 2020-01-20T15:36:58Z

@bors try

[WIP][DNM] Switch to GitHub Actions (maybe?) cc #4577 This is just an experiment. I don't think we have a consensus _if_ we should move away from travis/appveyor. GHA would let us run up to 20 concurrent jobs. Since we have 15 integration tests and 4 (linux, linux 32-bit, macos, windows) basic tests, we would be able to run everything concurrently. Also IIUC we only have to build Clippy once for every initegration test and then only check the repos. changelog: none

bors · 2020-01-20T15:37:07Z

⌛ Trying commit e6ecefb with merge 9619877...

flip1995 · 2020-01-20T15:42:03Z

@bors try

[WIP][DNM] Switch to GitHub Actions (maybe?) cc #4577 This is just an experiment. I don't think we have a consensus _if_ we should move away from travis/appveyor. GHA would let us run up to 20 concurrent jobs. Since we have 15 integration tests and 4 (linux, linux 32-bit, macos, windows) basic tests, we would be able to run everything concurrently. Also IIUC we only have to build Clippy once for every initegration test and then only check the repos. changelog: none

bors · 2020-01-20T15:42:11Z

⌛ Trying commit b767c40 with merge 870af4a...

flip1995 · 2020-01-20T16:03:32Z

@bors try

bors · 2020-01-20T16:03:39Z

⌛ Trying commit 0db62fa with merge 542dc23...

[WIP][DNM] Switch to GitHub Actions (maybe?) cc #4577 This is just an experiment. I don't think we have a consensus _if_ we should move away from travis/appveyor. GHA would let us run up to 20 concurrent jobs. Since we have 15 integration tests and 4 (linux, linux 32-bit, macos, windows) basic tests, we would be able to run everything concurrently. Also IIUC we only have to build Clippy once for every initegration test and then only check the repos. changelog: none

flip1995 · 2020-01-20T16:32:14Z

@bors try

[WIP][DNM] Switch to GitHub Actions (maybe?) cc #4577 This is just an experiment. I don't think we have a consensus _if_ we should move away from travis/appveyor. GHA would let us run up to 20 concurrent jobs. Since we have 15 integration tests and 4 (linux, linux 32-bit, macos, windows) basic tests, we would be able to run everything concurrently. ~~Also IIUC we only have to build Clippy once for every initegration test and then only check the repos.~~ Nope, dependent jobs exist, but they won't keep the artifacts (not even the checkout). changelog: none

bors · 2020-01-20T16:32:22Z

⌛ Trying commit 0db62fa with merge 43fbee2...

flip1995 · 2020-01-20T16:32:40Z

@bors try

bors · 2020-01-20T16:32:47Z

⌛ Trying commit 271a168 with merge 75da292...

[WIP][DNM] Switch to GitHub Actions (maybe?) cc #4577 This is just an experiment. I don't think we have a consensus _if_ we should move away from travis/appveyor. GHA would let us run up to 20 concurrent jobs. Since we have 15 integration tests and 4 (linux, linux 32-bit, macos, windows) basic tests, we would be able to run everything concurrently. ~~Also IIUC we only have to build Clippy once for every initegration test and then only check the repos.~~ Nope, dependent jobs exist, but they won't keep the artifacts (not even the checkout). changelog: none

flip1995 · 2020-01-20T16:42:56Z

@bors try

bors · 2020-01-20T16:43:04Z

⌛ Trying commit 470710b with merge a5457ab...

[WIP][DNM] Switch to GitHub Actions (maybe?) cc #4577 This is just an experiment. I don't think we have a consensus _if_ we should move away from travis/appveyor. GHA would let us run up to 20 concurrent jobs. Since we have 15 integration tests and 4 (linux, linux 32-bit, macos, windows) basic tests, we would be able to run everything concurrently. ~~Also IIUC we only have to build Clippy once for every initegration test and then only check the repos.~~ Nope, dependent jobs exist, but they won't keep the artifacts (not even the checkout). changelog: none

flip1995 · 2020-01-20T16:56:16Z

And now with cache

@bors r+

bors · 2020-01-20T16:56:18Z

📋 Looks like this PR is still in progress, ignoring approval.

Hint: Remove [WIP] from this PR's title when it is ready for review.

This is already checked by clippy_dev.yml GHA

Keep the fallback to compile-time environment

Some call it the integration integration

flip1995 · 2020-01-23T11:23:32Z

Try run successful. And it only took 21m32s without a cache vs ~30m on travis with cache.

Let's try it with cache (maybe this time remark runs? 🙏):

@bors try

bors · 2020-01-23T11:23:40Z

⌛ Trying commit 1d17002 with merge 8dd70d3...

bors · 2020-01-23T11:24:04Z

💔 Test failed - status-appveyor

flip1995 · 2020-01-23T12:13:23Z

12m21 with cache.

flip1995 · 2020-01-23T12:19:41Z

@Manishearth can you add a SSH key as a rust-lang/rust-clippy repo secret with the name DEPLOY_KEY? GHA Doc for adding secrets

flip1995 · 2020-01-23T13:46:28Z

@bors try

bors · 2020-01-23T13:46:36Z

⌛ Trying commit cd9b5d3 with merge 80e557d...

bors · 2020-01-23T13:46:57Z

💔 Test failed - status-appveyor

flip1995 · 2020-01-23T14:06:22Z

Remark just won't run on try pushes 🤔

flip1995 · 2020-01-23T14:48:58Z

@bors try

bors · 2020-01-23T14:49:07Z

⌛ Trying commit 8d1e233 with merge 5e2d140...

bors · 2020-01-23T14:49:31Z

💔 Test failed - status-appveyor

Manishearth · 2020-01-23T19:34:49Z

Done! I've added a deploy key, created in the deploy key section of settings.

Rate limit of 60 applies org wide, let's not spam. Thanks pietroalbini for the hint

flip1995 · 2020-01-24T13:22:58Z

Closing in favor of #5088

flip1995 added S-needs-discussion Status: Needs further discussion before merging or work can be started S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Jan 20, 2020

mati865 reviewed Jan 20, 2020

View reviewed changes

Comment thread .github/workflows/integration.yml Outdated

flip1995 added 6 commits January 23, 2020 12:11

Add Clippy Test (bors) to GHA

ddefa84

Ignore fmt test in GHA CI

9a1275e

This is already checked by clippy_dev.yml GHA

Check if changelog exists

0cb62dc

Get {RUSTUP,MULTIRUST}_{HOME,TOOLCHAIN} from runtime environment

6ed5ad2

Keep the fallback to compile-time environment

Add Clippy Test to GHA

e6467b4

Move integration tests in clippy_bors.yml

cbc046b

Some call it the integration integration

flip1995 added 8 commits January 24, 2020 14:09

Add deployment to GHA

974f992

Cleanup

a0b8ed4

Add GHA badge to README.md

cc9883a

[WIP] Remove Travis+AppVeyor badges

b827485

[WIP] Remove old CI files

25c7f65

Cancle builds on new commits

f803af2

Limit parallel jobs on try/r+ runs

dc3c7f1

Rate limit of 60 applies org wide, let's not spam. Thanks pietroalbini for the hint

Test deployment

d3e908a

flip1995 mentioned this pull request Jan 24, 2020

Switch to GitHub Actions - Part 2 - From within #5088

Merged

11 tasks

flip1995 mentioned this pull request Nov 14, 2020

Add sysroot detection in rustdoc rust-lang/rust#78926

Closed

Conversation

flip1995 commented Jan 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

flip1995 commented Jan 20, 2020

Uh oh!

bors commented Jan 20, 2020

Uh oh!

flip1995 commented Jan 20, 2020

Uh oh!

flip1995 commented Jan 20, 2020

Uh oh!

bors commented Jan 20, 2020

Uh oh!

flip1995 commented Jan 20, 2020

Uh oh!

bors commented Jan 20, 2020

Uh oh!

Uh oh!

flip1995 commented Jan 20, 2020

Uh oh!

bors commented Jan 20, 2020

Uh oh!

flip1995 commented Jan 20, 2020

Uh oh!

bors commented Jan 20, 2020

Uh oh!

flip1995 commented Jan 20, 2020

Uh oh!

bors commented Jan 20, 2020

Uh oh!

flip1995 commented Jan 20, 2020

Uh oh!

bors commented Jan 20, 2020

Uh oh!

flip1995 commented Jan 20, 2020

Uh oh!

bors commented Jan 20, 2020

Uh oh!

flip1995 commented Jan 20, 2020

Uh oh!

bors commented Jan 20, 2020

Uh oh!

flip1995 commented Jan 23, 2020

Uh oh!

bors commented Jan 23, 2020

Uh oh!

bors commented Jan 23, 2020

Uh oh!

flip1995 commented Jan 23, 2020

Uh oh!

flip1995 commented Jan 23, 2020

Uh oh!

flip1995 commented Jan 23, 2020

Uh oh!

bors commented Jan 23, 2020

Uh oh!

bors commented Jan 23, 2020

Uh oh!

flip1995 commented Jan 23, 2020

Uh oh!

flip1995 commented Jan 23, 2020

Uh oh!

bors commented Jan 23, 2020

Uh oh!

bors commented Jan 23, 2020

Uh oh!

Manishearth commented Jan 23, 2020

Uh oh!

flip1995 commented Jan 24, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

flip1995 commented Jan 20, 2020 •

edited

Loading