[missing_fields_in_debug]: make sure self type is an adt#11069
Merged
Conversation
rustbot
added
the
S-waiting-on-review
Alexendoo
approved these changes
Jul 2, 2023
Member
|
We might be able to write a Thanks again! @bors r+ |
Contributor
Contributor
Contributor
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
flip1995
added
beta-nominated
Member
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 17, 2023
…k-Simulacrum [beta] Clippy backports for ICE fixes This backports PRs to beta, that fix ICEs, some lint grouping and FP fixes. Namely: - rust-lang/rust-clippy#11191 - rust-lang/rust-clippy#11172 - rust-lang/rust-clippy#11130 - rust-lang/rust-clippy#11106 - rust-lang/rust-clippy#11104 - rust-lang/rust-clippy#11077 - rust-lang/rust-clippy#11070 (This PR is not synced to the Rust repo yet, but I will open a separate PR to get it into `master`, before beta is branched: rust-lang#114938) - rust-lang/rust-clippy#11069 Kind of a big backport, but most of it is tests. r? `@Mark-Simulacrum` cc `@Manishearth`
xFrednet
removed
the
beta-accepted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11063, another ICE that can only happen in core.
This lint needs the
DefIdof the implementor to get its fields, but that ICEs if the implementor does not have aDefId(as is the case with primitive types, e.g.impl Debug for bool), which is where this ICE comes from.This PR changes the check I added in #10897 to be more... robust against
Debugimplementations we don't want to lint.Instead of just checking if the self type is a type parameter and "special casing" one specific case we don't want to lint, we should probably rather just check that the self type is either a struct, an enum or a union and only then continue.
That prevents weird edge cases like this one that can only happen in core.
Again, I don't know if it's even possible to add a test case for this since one cannot implement
Debugfor primitive types outside of the crate that definedDebug(core).I did make sure that this PR no longer ICEs on
impl<T> Debug for Tandimpl Debug for bool.Maybe writing such a test is possible with
#![no_core]and then re-defining theDebugtrait or something like that...?changelog: [
missing_fields_in_debug]: make sure self type is an adt (fixes an ICE in core)r? @Alexendoo (reviewed the last PRs for this lint)