Skip 4 crates with broken beta version parsing#817
Conversation
|
At least some of these (all but forkable appear to just be graphicmagic-sys) are using rust-bindgen to parse the version the issue rust-lang/rust-bindgen#3152 was recently fixed and it should just need a dependency update to fix the crates that are using it. |
|
All four of these crates still have broken beta version parsing. See https://crater-reports.s3.amazonaws.com/beta-1.96-2/index.html Should this PR be merged, then? |
|
Let's merge this for now, if someone is willing to do the work of reassessing later, more than happy to review / undo |
This comment was marked as outdated.
This comment was marked as outdated.
|
(I forgot I can push, rebased) |
Head branch was pushed to by a user without write access
|
I also just force-pushed a rebase because I didn't see your latest comment. Not sure if I messed up anything 😅 |
|
Nah it's fine, it wasn't queued yet |
|
... what happened? |
|
There's a test failure? Is this spurious? |
Not sure |
|
Looks like the error code returned by the beta compiler no longer matches the expectation. This should be a non-spurious error caused by beta changing over time. https://github.com/rust-lang/crater/actions/runs/25092719910/job/73522306965#step:4:10129 |
Discovered in rust-lang/rust#149833