Add new feature resolver.#7820

Merged

bors merged 22 commits into

rust-lang:masterfrom

ehuss:features2-split

Feb 20, 2020

Commits on Feb 20, 2020

Move rustc target collection out of bcx.
ehuss
committed
Add a RequestedFeatures struct to hold cli features.
ehuss
committed
Add new feature resolver.
ehuss
committed
Ensure dev-dep features are unified if any are used.
ehuss
committed
Do not store `requested_features` in FeatureResolver.
ehuss
committed
Add some comments to help clarify some features stuff from review.
ehuss
committed
Add test for build script being run multiple times.
ehuss
committed
Consolidate -Zpackage-features member iteration logic.
ehuss
committed
Add a cyclical dev-dep test.
ehuss
committed
Add `-Zfeatures=all` option.
ehuss
committed
Add comment explaining dep_kind in compute_deps_custom_build.
ehuss
committed
Rewrite new feature resolver to simplify DepKind handling.
ehuss
committed
Fix `cargo clean -p` crashing with -Zfeatures.
ehuss
committed
Fix bug where required-features didn't work with -Zfeatures=build_dep correctly.
ehuss
committed
Change have_dev_units from a bool to enum HasDevUnits for clarity.
ehuss
committed
Change for_build_dep from a bool to enum FeaturesFor for clarity.
ehuss
committed
Compute dep_for_build in one place.
ehuss
committed
Try to remove some rightwards drift.
ehuss
committed
Try to clarify some things about UnitFor build flags.
ehuss
committed
Add comment trying to explain recursion and optional dependencies.
ehuss
committed
Add comment on relationship of RunCustomBuild and UnitFor::host.
ehuss
committed
Fix bug where an optional dependency is disabled in one fork, and enabled in another.
ehuss
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add new feature resolver.#7820

Add new feature resolver.#7820
bors merged 22 commits into
rust-lang:masterfrom
ehuss:features2-split

Commits on Feb 20, 2020

Move rustc target collection out of bcx.

Add a RequestedFeatures struct to hold cli features.

Add new feature resolver.

Ensure dev-dep features are unified if any are used.

Do not store `requested_features` in FeatureResolver.

Add some comments to help clarify some features stuff from review.

Add test for build script being run multiple times.

Consolidate -Zpackage-features member iteration logic.

Add a cyclical dev-dep test.

Add `-Zfeatures=all` option.

Add comment explaining dep_kind in compute_deps_custom_build.

Rewrite new feature resolver to simplify DepKind handling.

Fix `cargo clean -p` crashing with -Zfeatures.

Fix bug where required-features didn't work with -Zfeatures=build_dep correctly.

Change have_dev_units from a bool to enum HasDevUnits for clarity.

Change for_build_dep from a bool to enum FeaturesFor for clarity.

Compute dep_for_build in one place.

Try to remove some rightwards drift.

Try to clarify some things about UnitFor build flags.

Add comment trying to explain recursion and optional dependencies.

Add comment on relationship of RunCustomBuild and UnitFor::host.

Fix bug where an optional dependency is disabled in one fork, and enabled in another.