Adding examples for CPU-intensive work section of chapter 6#263
Open
nt54hamnghi wants to merge 2 commits into
Open
Adding examples for CPU-intensive work section of chapter 6#263nt54hamnghi wants to merge 2 commits into
nt54hamnghi wants to merge 2 commits into
Conversation
nt54hamnghi
force-pushed
the
nt54hamnghi/add-chap-6-examples
branch
from
e6f43ed to
37b9c9c
Compare
nrc
reviewed
May 14, 2026
Member
nrc
left a comment
nrc
left a comment
There was a problem hiding this comment.
A couple of minor suggestions, otherwise looks good, thanks!
| async fn main() { | ||
| let contents = tokio::task::spawn_blocking(|| { | ||
| std::fs::read_to_string("file.txt").unwrap() | ||
| println!("{contents}"); |
Member
There was a problem hiding this comment.
The variable contents is not in scope here.
| for i in 0..100_000_000 { | ||
| sum = sum.wrapping_add(i * i); | ||
| } | ||
| input * 42 |
Member
There was a problem hiding this comment.
should this be in the loop or connected with sum?
| // Use rayon's parallel iterators to compute the results in parallel | ||
| let results = data.into_par_iter().map(compute).collect::<Vec<_>>(); | ||
| // Send the result back to Tokio. | ||
| send.send(results).expect("Failed to send results to Tokio"); |
Member
There was a problem hiding this comment.
I would use unwrap rather than expect here and elsewhere
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.