Add fallback HrnResolver to LDK onion-message resolver#23
Open
benthecarman wants to merge 2 commits into
Open
Conversation
benthecarman
force-pushed
the
lnurl-fallback
branch
5 times, most recently
from
cc4f29c to
64bd50f
Compare
benthecarman
force-pushed
the
lnurl-fallback
branch
from
64bd50f to
f627ec7
Compare
TheBlueMatt
reviewed
May 11, 2026
benthecarman
force-pushed
the
lnurl-fallback
branch
2 times, most recently
from
e53ce08 to
dd87054
Compare
TheBlueMatt
reviewed
May 11, 2026
The onion-message DNSSEC resolver cannot satisfy LNURL lookups and also cannot run when the network graph contains no DNS-resolving nodes. This adds an optional HTTPHrnResolver as a fallback to resolve which is used in those cases and for all LNURL resolution.
benthecarman
force-pushed
the
lnurl-fallback
branch
from
dd87054 to
d4ea9b1
Compare
TheBlueMatt
reviewed
May 14, 2026
| } | ||
| Box::pin(async move { Err(e) }) | ||
| }, | ||
| Ok(recv) => Box::pin(async move { Ok(recv.await) }), |
Member
There was a problem hiding this comment.
Hmm, I believe in the case that the HRN does not resolve to any DNSSEC name (and only uses LNURL) this will simply silently time out and there won't be any LNURL attempt made. We should figure out what to do here, I guess we have to have a second or two timeout here before we attempt LNURL and then we poll both LNURL and DNSSEC and return whichever returns a valid response first (if either does)?
Contributor
Author
There was a problem hiding this comment.
for that then we need a runtime then, no?
Member
There was a problem hiding this comment.
Hmmmmmm, I think instead we should do lightning/blips#71 and fallback if we get a failure response.
Contributor
Author
There was a problem hiding this comment.
yeah that makes sense to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The onion-message DNSSEC resolver cannot satisfy LNURL lookups and also cannot run when the network graph contains no DNS-resolving nodes. Allow callers to plug in an arbitrary fallback HrnResolver (such as HTTPHrnResolver) which is consulted in those cases and used for all LNURL resolution.