Skip to content

Add PianoQueen-Music Plugin#13350

Merged
runelite-github-app[bot] merged 5 commits into
runelite:masterfrom
LogicalSoIutions:PianoQueen-Music
Jul 7, 2026
Merged

Add PianoQueen-Music Plugin#13350
runelite-github-app[bot] merged 5 commits into
runelite:masterfrom
LogicalSoIutions:PianoQueen-Music

Conversation

@LogicalSoIutions

Copy link
Copy Markdown
Contributor

Add's the PianoQueen plugin.

Let's users set one of the recordings from PianoQueen as their sound when they enter their POH and also replaces them in the in-game Audio Player so they can pick to listen to them whenever they want.

Big thanks to alowaniak for having easy to understand and re-use code making this take a lot less time than it should have.

@runelite-github-app

runelite-github-app Bot commented Jul 6, 2026

Copy link
Copy Markdown

@runelite-github-app

runelite-github-app Bot commented Jul 6, 2026

Copy link
Copy Markdown

Feedback:

  • javax.sound.sampled.AudioSystem.getAudioInputStream: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.SourceDataLine.close: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.AudioInputStream.read: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.AudioFormat$Encoding.PCM_SIGNED: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.AudioSystem.getLine: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.Line: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.AudioInputStream: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.DataLine$Info.<init>: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.AudioInputStream.getFrameLength: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.AudioFormat: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.SourceDataLine.start: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.SourceDataLine.open: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.DataLine$Info: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • java.lang.Exception.printStackTrace: system i/o, use a logger instead.
  • javax.sound.sampled.SourceDataLine.drain: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.UnsupportedAudioFileException: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.AudioSystem: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.SourceDataLine: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.Line$Info: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • java.lang.System.out: system i/o, use a logger instead.
  • javax.sound.sampled.Mixer.getLine: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.SourceDataLine.write: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.AudioFormat$Encoding: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.AudioFormat.<init>: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.DataLine: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.AudioFormat.getFrameRate: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.LineUnavailableException: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.Mixer: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead

A new scan will be automatically performed on the next push to the PR branch.


Internal use only: Reviewer details Maintainer details

@Bram91

Bram91 commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Do you have the creator's permission to use these sounds?

@Bram91 Bram91 added the waiting for author waiting for the pr author to make changes or respond to questions label Jul 6, 2026
@LogicalSoIutions

LogicalSoIutions commented Jul 6, 2026 via email

Copy link
Copy Markdown
Contributor Author

@runelite-github-app runelite-github-app Bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Jul 6, 2026
@riktenx

riktenx commented Jul 7, 2026

Copy link
Copy Markdown
Member

you should just encode these as .wav so you don't need the jacomp3 dependency and can set build=standard. this would make your plugin eligible for automatic review and you would not have to wait for someone to manually review your plugin.

@riktenx riktenx added the waiting for author waiting for the pr author to make changes or respond to questions label Jul 7, 2026
@LogicalSoIutions

LogicalSoIutions commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

I originally had them as WAV files but it was ~320mb for all the sounds as WAV compared to ~36mb as MP3

@runelite-github-app runelite-github-app Bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Jul 7, 2026
@riktenx

riktenx commented Jul 7, 2026

Copy link
Copy Markdown
Member

that is not a problem on our end since you're downloading the files from github, but it's your call. no idea when this will be reviewed though, if ever, there is not that much capacity/desire for manual review these days

Revert back to WAV system
@LogicalSoIutions

Copy link
Copy Markdown
Contributor Author

Forgot to post my comment when I pushed the commit, but, switched back to WAV

@riktenx

riktenx commented Jul 7, 2026

Copy link
Copy Markdown
Member

we do not allow new usages of script 9238 because it triggers a server action, misuse is liable to trigger anticheat bans

@riktenx riktenx added the waiting for author waiting for the pr author to make changes or respond to questions label Jul 7, 2026
@runelite-github-app runelite-github-app Bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Jul 7, 2026
Removed client.runScript and script 9238
@runelite-github-app runelite-github-app Bot merged commit 5e6a083 into runelite:master Jul 7, 2026
2 of 3 checks passed
@LogicalSoIutions LogicalSoIutions deleted the PianoQueen-Music branch July 8, 2026 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants