Add PianoQueen-Music Plugin#13350
Conversation
|
New plugin |
|
Feedback:
A new scan will be automatically performed on the next push to the PR branch. Internal use only: Reviewer details Maintainer details |
|
Do you have the creator's permission to use these sounds? |
|
Yes, I worked with her privately via Discord. Can share screenshots if
needed.
…On Mon, Jul 6, 2026 at 01:44 Gamma91 ***@***.***> wrote:
*Bram91* left a comment (runelite/plugin-hub#13350)
<#13350 (comment)>
Do you have the creator's permission to use these sounds?
—
Reply to this email directly, view it on GitHub
<#13350?email_source=notifications&email_token=AP7WJ7JQLUJ2HORT5IJO3F35DNRHHA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIOBZGA4DANJRGU3KM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#issuecomment-4890805156>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AP7WJ7JPYLSGRXBHV45NVU35DNRHHAVCNFSNUABFKJSXA33TNF2G64TZHMZDENZWHA3DCNRRHNEXG43VMU5TIOBRG4ZDOMBYHA22C5QC>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
you should just encode these as .wav so you don't need the jacomp3 dependency and can set build=standard. this would make your plugin eligible for automatic review and you would not have to wait for someone to manually review your plugin. |
|
I originally had them as WAV files but it was ~320mb for all the sounds as WAV compared to ~36mb as MP3 |
|
that is not a problem on our end since you're downloading the files from github, but it's your call. no idea when this will be reviewed though, if ever, there is not that much capacity/desire for manual review these days |
Revert back to WAV system
|
Forgot to post my comment when I pushed the commit, but, switched back to WAV |
|
we do not allow new usages of script 9238 because it triggers a server action, misuse is liable to trigger anticheat bans |
Removed client.runScript and script 9238
Add's the PianoQueen plugin.
Let's users set one of the recordings from PianoQueen as their sound when they enter their POH and also replaces them in the in-game Audio Player so they can pick to listen to them whenever they want.
Big thanks to alowaniak for having easy to understand and re-use code making this take a lot less time than it should have.