video/vp6: Init nihav decoder with encoded size, not display size#23665
Open
SuchAFuriousDeath wants to merge 1 commit intoruffle-rs:masterfrom
Open
video/vp6: Init nihav decoder with encoded size, not display size#23665SuchAFuriousDeath wants to merge 1 commit intoruffle-rs:masterfrom
SuchAFuriousDeath wants to merge 1 commit intoruffle-rs:masterfrom
Conversation
The Vp6Decoder wrapper was passing `header.disp_w/disp_h * 16` to `VP56Decoder::init`, but those are the displayed dimensions, not the encoded ones. Fixes ruffle-rs#23662
Member
|
This is probably correct (at least it feels like it should be), and I'm a bit embarrassed... 🫣 |
Contributor
|
Weird edge cases are a great reason to add tests. If it was missed once it can be missed again. |
Collaborator
Author
|
I wouldn't call this an edge case, it is wrong, it's just rare for itself to manifest. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Vp6Decoder wrapper was passing
header.disp_w/disp_h * 16toVP56Decoder::init, but those are the displayed dimensions, not the encoded ones.Fixes #23662
Not sure if we want a test is necessary for a change like this.
Testing
I'd like to wait for the swf in #23662, if it's not provided, I guess we could make a test from scratch.
Checklist