web: Modernize player UI (context menu, modals, panic screen, save manager)#23500
web: Modernize player UI (context menu, modals, panic screen, save manager)#23500robinmiau wants to merge 5 commits intoruffle-rs:masterfrom
Conversation
Refactor panic component to improve error detail handling.
Added new CSS variables for dark mode and modal styles. Updated styles for panic overlay and modal components.
|
Looks great, thank you! I do want to preserve the attention-grabbing nature of the panic screen though - that's why we have the orange gradient background. Maybe adding an error icon to the initial panic screen would help with that? |
|
I like the new design! Although I'd prefer to keep how the panic screen looks. We don't expect panicking often, so an attention grabbing gradient seems perfect and easily differentiates from the content erroing out. |
|
I think that looks better. Can we split this PR into multiple ones? It's very difficult to review large changes. It would be nice to have a separate PR for each component, or if changes touch multiple components, they should be limited in scope. |
|
@kjarosh This might be tricky, as all these changes involve the same files. Wouldn't there be merge conflicts if we split them into multiple PRs? |
|
For instance: semantically, there's no reason for the behavioral changes of the context menu to be in the same PR as the UI redesign, is there? It will be difficult to do a review, because we'll have to review everything at one go, and it will take considerably longer than in separate PRs. Usually you'd do incremental changes, PRs can depend on each other and we can merge them sequentially too. |
|
So should I start with a smaller PR and base the subsequent ones on that? |
|
At the end of the day it's your call, I think this PR is splittable and we should do it because the review process will be easier. |

Modernized the web player's built-in UI with several polish improvements across the context menu, modals, panic screen, and save manager.
Screenshots
Context menu
Old:

New:

Panic screen
Old:

New:

File manager modal
Old:

New:
