Skip to content

Revert "ci: Freeze rustc for nightly web builds to 1.81.0"#18399

Merged
danielhjacobs merged 1 commit intomasterfrom
revert-18397-danielhjacobs-patch-3
Jan 10, 2025
Merged

Revert "ci: Freeze rustc for nightly web builds to 1.81.0"#18399
danielhjacobs merged 1 commit intomasterfrom
revert-18397-danielhjacobs-patch-3

Conversation

@torokati44
Copy link
Copy Markdown
Member

Reverts #18397.

To be merged once wasm-bindgen/wasm-bindgen#4213 is merged and released, so wasm-bindgen/wasm-bindgen#4227 can be fixed properly.

Also referencing wasm-bindgen/wasm-bindgen#4211.

@torokati44 torokati44 added A-build Area: Build scripts & CI T-chore Type: Chore (like updating a dependency, it's gotta be done) labels Oct 28, 2024
@danielhjacobs
Copy link
Copy Markdown
Contributor

Referencing #18528

@danielhjacobs
Copy link
Copy Markdown
Contributor

Two options for merging this PR:

  1. Merge web: Make npm run build:dual-wasm create an MVP vanilla WASM module and make the default WASM module be with extensions #18528, integrate it into CI with these commands: web: Make npm run build:dual-wasm create an MVP vanilla WASM module and make the default WASM module be with extensions #18528 (comment), and then merge this, therefore supporting all the browsers we currently support.
  2. Accept the loss of Pale Moon support, Basilisk support, and Safari 14.1 as acceptable, announce it, note it on https://github.com/ruffle-rs/ruffle/wiki#web, merge web: Improve error when WASM extensions are unsupported but only the module which uses them is available #18838, and then merge this, therefore adding a message that browsers without reference-types are unsupported.

@danielhjacobs danielhjacobs force-pushed the revert-18397-danielhjacobs-patch-3 branch from 6ec0c8c to 51f18f6 Compare January 10, 2025 16:39
@danielhjacobs danielhjacobs marked this pull request as ready for review January 10, 2025 16:39
@danielhjacobs danielhjacobs enabled auto-merge (rebase) January 10, 2025 16:39
@danielhjacobs danielhjacobs merged commit d598ca9 into master Jan 10, 2025
@kjarosh kjarosh deleted the revert-18397-danielhjacobs-patch-3 branch June 29, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-build Area: Build scripts & CI T-chore Type: Chore (like updating a dependency, it's gotta be done)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants