Use rubyatscale/rubyfmt-action for the Rubyfmt CI check - #71
Merged
Conversation
Replaces the manual 'download+install rubyfmt v0.14.1, then run rubyfmt --check' steps with the published rubyatscale/rubyfmt-action GitHub Action (https://github.com/rubyatscale/rubyfmt-action), which downloads a pinned, checksum-verified rubyfmt release. This also picks up newer rubyfmt releases automatically (the action currently defaults to 0.14.2-10) instead of staying pinned to 0.14.1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Install rubyfmt+Check formattingsteps in therubyfmtCI job with the newly publishedrubyatscale/rubyfmt-action.rubyfmtrelease (currently0.14.2-10, vs. the0.14.1this repo was pinned to), and future version bumps happen centrally in that repo instead of needing a PR here each time.Test plan
rubyfmtjob should behave the same as before, modulo the newerrubyfmtversion).