fix(benchmark): resolve file URLs with spaces on Windows#2893
Open
2543679596-sketch wants to merge 1 commit into
Open
fix(benchmark): resolve file URLs with spaces on Windows#28932543679596-sketch wants to merge 1 commit into
2543679596-sketch wants to merge 1 commit into
Conversation
|
|
2543679596-sketch
force-pushed
the
fix/windows-file-url-benchmark-paths
branch
from
4e91a05 to
acbdb8d
Compare
2543679596-sketch
force-pushed
the
fix/windows-file-url-benchmark-paths
branch
from
acbdb8d to
253ff2b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
new URL(...).pathname.replace(...)path handling in benchmark scripts withfileURLToPath(...)%20paths and leading/C:/...drive pathsFixes #2891
Test plan
bun build scripts/benchmark/run.ts scripts/benchmark/rebuild.ts --outdir .tmp-bun-build --target=bunfile:///C:/Users/John%20Doe/...now resolves toC:\Users\John Doe\...instead of/C:/Users/John%20Doe/...git diff --checkNote: I could not run the full benchmark scripts locally because they require
multipass; I verified the scripts bundle and the Windows path conversion directly.