fix: detect absolute rtk path in Claude hook settings#2885
Open
TaKO8Ki wants to merge 2 commits into
Open
Conversation
Contributor
|
Hey @TaKO8Ki Thanks for addressing this issue src/hooks/init.rs (remove_hook_from_json) still uses exact match if command.contains(REWRITE_HOOK_FILE) || command == CLAUDE_HOOK_COMMAND should use your is_claude_hook_command Your coding in constant.rs this file was dedicated to pure constant, just a nit but to keep it clean it may belong to a more proper file I tested code locally it correctly fix the issue |
Author
|
@aeppling Hi. Thank you for the review. I have fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2884
Summary
rtkis configured with an absolute pathTest plan
settings.jsonand confirmed that this implementation works as expected in my local environment.{ "hooks": { "PreToolUse": [{ "matcher": "Bash", "hooks": [{ "type": "command", "command": "/opt/homebrew/bin/rtk hook claude", "timeout": 5 }] }] } }cargo fmt --all && cargo clippy --all-targets && cargo testrtk <command>output inspected