-
Notifications
You must be signed in to change notification settings - Fork 37
Add direct Kubernetes off-host execution support to Connect chart #786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 64 commits
Commits
Show all changes
67 commits
Select commit
Hold shift + click to select a range
394d20f
Add native-Go OHE support to Connect chart and update RBAC
dbkegley 58e88ac
Update charts/rstudio-connect/values.yaml
dbkegley c702ebd
Update charts/rstudio-connect/values.yaml
dbkegley 07f0257
Update charts/rstudio-connect/values.yaml
dbkegley 702bb35
Refactor RBAC: dedicated permissions for native-Go runner
lucasrod16 8457b3e
Bump chart version to 0.9.0
lucasrod16 7894853
Rename values key from kubernetes to backends.kubernetes
lucasrod16 97f9f23
Rename defaultJobOverlay/defaultServiceOverlay to defaultResourceJobB…
lucasrod16 93d76d9
Move init container into chart logic and default defaultResourceJobBa…
lucasrod16 c6fc17b
Fix prestart volumeMount missing for native runner
lucasrod16 267c656
Add CI values file for native Kubernetes runner
lucasrod16 3a0b586
Add migration examples and gitignore notes.md
lucasrod16 6c66480
Add before/after launcher migration examples
lucasrod16 3a7313c
Fix prestart volumeMount guard and hardcoded resource base mount paths
lucasrod16 25a4c59
Add tests for prestart guard and custom resource base mount paths
lucasrod16 f6d3a72
Ensure rsc-volume mount on user-provided connect-content-init
lucasrod16 381182a
Add RBAC, configmap-prestart, and init image tag tests
lucasrod16 c8712a5
Tighten RBAC, checksum, and init tag test assertions
lucasrod16 3dffe84
Check both name and mountPath for connect-content rsc-volume mount
lucasrod16 381971f
Fail fast on reserved mountPath conflicts in job base
lucasrod16 73ca942
Update NEWS.md with 0.9.0 release notes and remove Go references
lucasrod16 fb984d7
Add command and defaultSecurityContext to migration examples
lucasrod16 9215537
Address review findings: docs accuracy and completeness
lucasrod16 c56643e
Guard config.Kubernetes dereferences with dig for nil safety
lucasrod16 9eefea6
Strip empty DefaultResource*Base from config before merge
lucasrod16 43d6d8f
Link executionEnvironments to chart README instead of Connect docs
lucasrod16 731a688
Simplify minimal migration docs and clarify DataDirPVCName auto-config
lucasrod16 599f089
Document runner-managed fields and overlay behavior in migration exam…
lucasrod16 0d482f7
Replace native terminology with direct Kubernetes runner
lucasrod16 35495d7
Replace migration terminology with upgrade per PR feedback
lucasrod16 6a596d3
Rename migration directory and files to upgrade
lucasrod16 0b205c4
Remove rollback-to-launcher guidance from upgrade docs
lucasrod16 8b8ecdf
Add upgrade callout in NOTES.txt when launcher.enabled with appVersio…
lucasrod16 0dc8f1c
Note profiles functionality is achievable via defaultResourceJobBase
lucasrod16 663ce4e
Remove unreleased Connect docs link from values.yaml
lucasrod16 410c705
Refactor minimal upgrade section into a mapping table
lucasrod16 e822a25
Remove internal-detail rows from values-with-no-equivalent table
lucasrod16 36edb90
Move important notes section to top of upgrade guide
lucasrod16 f221e80
Remove redundant sharedStorage note from minimal upgrade intro
lucasrod16 25ecd91
Add imagePullPolicy, resources, securityContext to backends defaultIn…
lucasrod16 5802894
Simplify config.Launcher row in upgrade table
lucasrod16 c7bc702
Split templateValues examples into dedicated navigable sections
lucasrod16 43b3e08
Reorder example sections by admin configuration priority
lucasrod16 174ccb7
Simplify pod security context example
lucasrod16 fb3c9e2
Use runAsNonRoot in security context example
lucasrod16 6763300
Update mountContent description to cover both launcher and backends.k…
lucasrod16 64007cd
Remove pre-release items for early merge
lucasrod16 223492b
Address PR review feedback from nihara-thomas
lucasrod16 7b22e7f
Use consistent upgrade terminology in title and sidebar
lucasrod16 e3682df
Validate config.Kubernetes does not conflict with backends.kubernetes
lucasrod16 8c8dbc9
Normalize config.Kubernetes.Enabled check to be case-insensitive
lucasrod16 35c9e4e
Add test for shared storage requirement with backends.kubernetes
lucasrod16 0c5a57b
Guard init container image override with hasKey check
lucasrod16 539a995
Test user-provided init container image is preserved
lucasrod16 b2ad07d
Add test validating Role rules for direct Kubernetes runner RBAC
lucasrod16 7aaffb2
Add tests for service.yaml configmap presence
lucasrod16 b9dc3ba
Add default apiVersion and kind to service base
lucasrod16 d819407
Update securityContext comment to mention backends.kubernetes
lucasrod16 c3ca637
Expand config generation comment to include backends.kubernetes
lucasrod16 2a09ea5
Update charts/rstudio-connect/values.yaml
lucasrod16 1952cfa
Add 0.9.0 upgrade guidance section linking to upgrade guide
lucasrod16 3ddb10a
Extract oheEnabled helper for launcher/kubernetes conditional
lucasrod16 78a1c28
Regenerate README.md
lucasrod16 d047cca
Fix upgrade guide link path in README.md.gotmpl
lucasrod16 f3af1cf
Add minimum Connect version callout to upgrade guide
lucasrod16 ced65d7
Validate kind on defaultResourceJobBase and defaultResourceServiceBase
lucasrod16 4288b45
Add tests for kind validation on job and service base
lucasrod16 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| dependencies: | ||
| - name: rstudio-library | ||
| repository: https://helm.rstudio.com | ||
| version: 0.1.35 | ||
| digest: sha256:59fe5e712690610495d2ff32c6c78cc136e9685a785151d4cdba4b914d110f87 | ||
| generated: "2025-10-09T13:37:20.639004-05:00" | ||
| version: 0.1.36 | ||
| digest: sha256:cde061b0b7da43d7adbfcbc8d90e6d466d453dd707d8dad4f702fec6aeea103b | ||
| generated: "2026-04-01T12:03:45.783681-05:00" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| license: | ||
| file: | ||
| secret: pct-license | ||
| secretKey: pct.lic | ||
|
|
||
| launcher: | ||
| enabled: false | ||
|
|
||
| backends: | ||
| kubernetes: | ||
| enabled: true | ||
|
|
||
| # a PVC is required for Connect to run in OHE (now the default) | ||
| sharedStorage: | ||
| create: true | ||
| # normally this should be ReadWriteMany, setting just for CI | ||
| accessModes: | ||
| - ReadWriteOnce |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: link to updated Connect resource base docs