-
Notifications
You must be signed in to change notification settings - Fork 40
Feat: Lineage telemetry plugin — two facts-only spans per exchange #761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JoshSag
wants to merge
4
commits into
rossoctl:main
Choose a base branch
from
s-and-p-team:lane/lineage-telemetry-plugin
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
cf3a922
Feat: Add the lineage-telemetry plugin
JoshSag d43523f
Feat: Register lineage-telemetry behind an exclude_plugin build tag
JoshSag 0071332
Fix: Address lineage-telemetry review feedback + resolve go.mod conflict
faraway7 d4bc0a2
Merge remote-tracking branch 'origin/main' into lane/lineage-telemetr…
faraway7 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
🔎 Supported by static analysis
🏁 Script executed:
Repository: rossoctl/cortex
Length of output: 1356
🏁 Script executed:
Repository: rossoctl/cortex
Length of output: 10096
Keep the authlib module on the required Go 1.25 target.
authbridge/authlib/go.moddeclaresgo 1.26.5, while the repository convention requires Go 1.25 for AuthBridge library code. Align the directive with Go 1.25, or update the convention and supported toolchains together.🤖 Prompt for AI Agents
Sources: Coding guidelines, MCP tools