Execute process refactor - #215

Open

roger-strain wants to merge 19 commits into

ros2:rollingfrom

roger-strain:execute-process-refactor

Commits on Dec 15, 2023

Refactor Node action into description classes

Roger Strain
authored and
vknisley-swri
committed
6689fe0
Refactor arguments from nodes, address feedback

Roger Strain
authored and
vknisley-swri
committed
e5ef999
Fix missing node name parameter

Roger Strain
authored and
vknisley-swri
committed
83c4529
Improve node name handling, unit test fixes, more

Roger Strain
authored and
vknisley-swri
committed
87948a8
Add node prefix to command line remaps

Roger Strain
authored and
vknisley-swri
committed
2f4937d
Move NodeActionExtension to descriptions/Node.py

mlanting
authored and
vknisley-swri
committed
b38ea73
Use node_description and ros_executable instead of node_action.

mlanting
authored and
vknisley-swri
committed
4be19e5
Updated function signature and accompanying documentation.

mlanting
authored and
vknisley-swri
committed
9ad74b5
WIP Fixes for failing tests.

mlanting
authored and
vknisley-swri
committed
f1ae020
Change "ros_params" string to "global_params" when getting params from

mlanting
authored and
vknisley-swri
committed
5f4ac9f
More unit test fixes.

mlanting
authored and
vknisley-swri
committed
1bb350e
More unit test fixes.

mlanting
authored and
vknisley-swri
committed
29788c4
Increase tolerance for timer tests from 0.1 seconds to 0.5 seconds

mlanting
authored and
vknisley-swri
committed
43f1912
removed license language to match aggreed upon format

mlanting
authored and
vknisley-swri
committed
b9531dd
Move Executable specific keyword args to kwargs instead of duplicating

mlanting
authored and
vknisley-swri
committed
d5b83d5
Remove 'node_' prefix from members and arguments.

mlanting
authored and
vknisley-swri
committed
4b45bc5
extend instead of assign expanded_parameter_arguments in tests.

mlanting
authored and
vknisley-swri
committed
846295c
Resolve SelectableGroups deprecation warning, using approach used to resolve https://github.com/ros2/ros2/issues/1254 by clalancette.
vknisley-swri
committed
32409af
Resolve arguments typing issue
vknisley-swri
committed
6e95e60

Navigation Menu

Uh oh!

Execute process refactor - #215

Execute process refactor#215
roger-strain wants to merge 19 commits into
ros2:rollingfrom
roger-strain:execute-process-refactor

Commits on Dec 15, 2023

Refactor Node action into description classes

Refactor arguments from nodes, address feedback

Fix missing node name parameter

Improve node name handling, unit test fixes, more

Add node prefix to command line remaps

Move NodeActionExtension to descriptions/Node.py

Use node_description and ros_executable instead of node_action.

Updated function signature and accompanying documentation.

WIP Fixes for failing tests.

Change "ros_params" string to "global_params" when getting params from

More unit test fixes.

More unit test fixes.

Increase tolerance for timer tests from 0.1 seconds to 0.5 seconds

removed license language to match aggreed upon format

Move Executable specific keyword args to kwargs instead of duplicating

Remove 'node_' prefix from members and arguments.

extend instead of assign expanded_parameter_arguments in tests.

Resolve SelectableGroups deprecation warning, using approach used to resolve https://github.com/ros2/ros2/issues/1254 by clalancette.

Resolve arguments typing issue