Ros2 port of map_msgs - #4
Conversation
One was three spaces, and the other was four spaces, so I switched both to fourspaces.
|
Looks good by me. I'm fine with with having ROS1/ROS2 in same repo, only comment would be that eventually this might want X-devel as branch name if we need different versions for different ROS releases (that is probably not likely for just messages). Any timeline on actions being ported to ROS2? |
That might come up in the future, but for now, I think just
Doesn't look like it will get in this release, but some community people already started looking at it: ros2/design#143 |
DO NOT MERGE, this is just for reference, the
ros2branch should remain separate for now.Hi guys, I went ahead and ported
map_msgsand put it on thisros2branch because we need it in the map display for rviz in ROS 2. I hope you guys don't mind that I put it on a branch rather than a fork.This does a few things:
map_msgsstd_msgs/Headerinstead ofHeader(required in ROS 2)move_base_msgsAMENT_IGNOREfile (likeCATKIN_IGNORE) for now since actions are still being portedIf you guys could close this pull request as an indication that this is all ok, that would be great. At that point I'd open a new issue to track that
move_base_msgsneeds porting when actions are done in ROS 2.Also, this repository may be able to have one branch for both ROS 1 and ROS 2 in the future, but that depends on some on going work to smooth migration. So I'll have to come back and touch things again when that's possible.
I also built this on top of #3 in the hope that gets merged at some point.
Please let me know if you guys have any issues with this or questions for me.
Thanks!