You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are some use cases where being able to specify the prefix in the non-macro xacro file is useful.
Adding this should have no impact on any existing use cases.
I can add this argument to the other "concrete" xacro files, but I believe in nearly all cases where this is relevant the user will favor using the generic file anyway.
As a side note, this argument is provided in the non-macro file of the ROS2 description repo.
There are some use cases where being able to specify the prefix in the non-macro xacro file is useful.
Could you give an example where this would be useful?
As you already write yourself, this .xacro file is supposed to be a top-level one and is not meant for composition. I'm having a hard time coming up with a use-case for a prefix.
An example would be when using external tooling to compose URDFs, but still wanting to utilize existing xacro files alongside/within those tools.
By virtue of what those tools are attempting, they essentially must be able to parse URDF properly, but may not support parsing/resolving xacro macros.
In such cases, it can be useful to have a top-level xacro file that essentially wraps the macro more or less 1:1, so that xacro itself can be called on that top-level file and the resulting valid URDF file fed into the other tool.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are some use cases where being able to specify the prefix in the non-macro xacro file is useful.
Adding this should have no impact on any existing use cases.
I can add this argument to the other "concrete" xacro files, but I believe in nearly all cases where this is relevant the user will favor using the generic file anyway.
As a side note, this argument is provided in the non-macro file of the ROS2 description repo.