Fix clang -Werror complains - #291
Open
v4hn wants to merge 3 commits into
Open
Conversation
clang -Werror complains about the obsolete `virtual` definition these days.
`char` is signed by default and `142 > std::numeric_limits<char>::max()` so clang -Werror complained.
clang 16 notices the unused return value.
Author
|
@gavanderhoorn any chance you could merge so we don't have to carry more and more bugfixes in the ros-o fork? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the individual commits for the details.
mark virtual overrides as override
correctly define
CONNECT_HANDSHAKEas unsignedfix bug with erase-remove idiom