Repository navigation
Conversation
A set is iterable but owns its storage and has no static length, so the C++ backend's stack allocation should default-construct it rather than assert on a size it cannot have.
The C++ runtime provides set<T>; CUDA has no equivalent.
layout-bad-path had no flags line, so it never reached verify-layouts and recorded a clean compile. build-inner-group was registered nowhere.
The rt harness references apps/rt/layouts, but the merge never brought the directory over. Splits that left tag values uncovered now use a wildcard arm, and counts materialized from a bitfield carry the cast the tree type needs.
Scion disabled both passes rather than teach them pointer groups, pointer-encoded child references, and bitfield split widths. Two collision schedules had real layout errors hidden behind that.
alignas can only raise alignment, so a layout asking for less than a wide vector member's natural alignment failed to compile.
Lost when the Scion merge dropped apps/wos; ported to the current layout syntax.
Its golden was left orphaned in the tree.
Scion deleted the source and left the golden behind.
Rewrite::visit(Access) called mutate on its own node, which dispatched straight back into it. A parent. access reached that path, so any implicit hierarchy crashed the compiler. Also resolve a variant field carried by a root argument, which validate_layout already accepts, and let a variant that stores nothing have an empty count arm.
Scion deleted apps/wos and the cl-cw-bvh8-idx layouts. Ported to the current layout syntax; the fcpw schedule still needs child-bound sorting.
A distinct configuration from align16, not a duplicate of it.
Removes results collection and the Embree and FCPW comparisons, and strips FCL from the collision driver. The apps still build and run on Bonsai alone.
The build regenerates these; the checked-in copies predate the vector and runtime-path changes.
It offers a median split as well as the surface-area heuristic.
Only the x86_64 override was re-blessed, so CI kept the old prologue.
Token::size() is an exhaustive switch with no default, so an IN token fell off the end of it. UBSan traps that in a Debug build, aborting every test that uses an interval bound.
std::source_location::column() differs between Apple Clang and GCC, so every golden recording it was host-specific.
The caret already marks the column, and a column taken from the host compiler made the diagnostic machine-specific.
Neither takes a value, but both skipped one.
Codegen tests now pass --target instead of inheriting the host's, so one golden is right on every machine and the per-arch override files are gone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to merge in all features/some sample apps, without all the benchmarking cruft and stuff.