Repository navigation
Ajr/pldi benchmarks fixes - #213
Merged
Merged
Conversation
printf is variadic, so the default argument promotions apply: a float arrives as a double and that is what "%f" reads. Pushing an f32 straight through left the upper half of the argument undefined, so every float this branch printed came out as 0.000000 -- correctness/llvm/print, correctness/llvm/exported-function, correctness/llvm/defer-sum and correctness/llvm/map all printed zeroes instead of their values. Ported from the same fix on main.
generic_fib, mismatched_types and struct_duplicate_default record the source line of the internal_assert that fires, and edits to Expr.cpp and Parser.cpp moved those asserts without the goldens being updated: Expr.cpp 340 -> 341 (BinOp of non-number or boolean types) Expr.cpp 276 -> 277 (implicit casting of types) Parser.cpp 451 -> 469 (duplicate default value for field) All three asserts have their condition on a single line, so the reported number does not depend on the compiler -- GCC and Clang only disagree about __LINE__ for a macro invocation that spans lines. The new values are byte identical to main's goldens, which pass under both.
The backend now emits 'using float3 = vector<float, 3>'; these still said vec3_float and would not compile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.